All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Heinz <thomasheinz@gmx.net>
To: linux-kernel@vger.kernel.org
Subject: NLMSG_ALIGNTO macro
Date: Wed, 26 Mar 2003 23:27:06 +0100	[thread overview]
Message-ID: <3E82293A.1020805@gmx.net> (raw)

Hi

include/linux/netlink.h says: #define NLMSG_ALIGNTO 4

I think NLMSG_ALIGNTO should be 8 because the data may be a
struct containing a 64 bit member which requires 64 bit
alignment. In this case NLMSG_DATA will not work properly if
NLMSG_LENGTH(0) % 8 != 0.

Currently this is a "theoretical" issue as
sizeof(struct nlmsghdr) == 16.

Do you agree that the definition of NLMSG_ALIGNTO should
be changed?


Regards,

Thomas

PS: Please CC to my private e-mail address as I'm currently
     not subscribed.


                 reply	other threads:[~2003-03-27  9:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E82293A.1020805@gmx.net \
    --to=thomasheinz@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.