All of lore.kernel.org
 help / color / mirror / Atom feed
* NLMSG_ALIGNTO macro
@ 2003-03-26 22:27 Thomas Heinz
  0 siblings, 0 replies; only message in thread
From: Thomas Heinz @ 2003-03-26 22:27 UTC (permalink / raw)
  To: linux-kernel

Hi

include/linux/netlink.h says: #define NLMSG_ALIGNTO 4

I think NLMSG_ALIGNTO should be 8 because the data may be a
struct containing a 64 bit member which requires 64 bit
alignment. In this case NLMSG_DATA will not work properly if
NLMSG_LENGTH(0) % 8 != 0.

Currently this is a "theoretical" issue as
sizeof(struct nlmsghdr) == 16.

Do you agree that the definition of NLMSG_ALIGNTO should
be changed?


Regards,

Thomas

PS: Please CC to my private e-mail address as I'm currently
     not subscribed.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-03-27  9:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-26 22:27 NLMSG_ALIGNTO macro Thomas Heinz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.