Au1000 ethernet patch

Au1000 ethernet patch

[Hartvig Ekner]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

The following patch fixes an error where ethernet minimum packets are 4 bytes too long. This caused certain
devices not to respond to ARP requests (which is a bug on their side as well, but.....).

/Hartvig



[-- Attachment #2: eth_patch --]
[-- Type: text/plain, Size: 655 bytes --]

Index: au1000_eth.h
===================================================================
RCS file: /home/cvs/linux/drivers/net/au1000_eth.h,v
retrieving revision 1.2.2.8
diff -u -r1.2.2.8 au1000_eth.h
--- au1000_eth.h	3 Mar 2003 06:40:30 -0000	1.2.2.8
+++ au1000_eth.h	28 Mar 2003 19:05:48 -0000
@@ -36,7 +36,7 @@
 #define MAX_BUF_SIZE 2048
 
 #define ETH_TX_TIMEOUT HZ/4
-#define MAC_MIN_PKT_SIZE 64
+#define MAC_MIN_PKT_SIZE 60
 
 #if defined(CONFIG_MIPS_PB1000) || defined(CONFIG_MIPS_PB1500) || defined(CONFIG_MIPS_PB1100) || defined(CONFIG_MIPS_DB1000) || defined(CONFIG_MIPS_DB1100) || defined(CONFIG_MIPS_DB1500)
 #define PHY_ADDRESS              0

Re: Au1000 ethernet patch

[Pete Popov]

On Fri, 2003-03-28 at 11:14, Hartvig Ekner wrote:
> The following patch fixes an error where ethernet minimum packets are 4 bytes too long. This caused certain
> devices not to respond to ARP requests (which is a bug on their side as well, but.....).


Thanks, I'll apply it later tonight.

Pete

> /Hartvig
> 
> 
> 
> ______________________________________________________________________
> 
> Index: au1000_eth.h
> ===================================================================
> RCS file: /home/cvs/linux/drivers/net/au1000_eth.h,v
> retrieving revision 1.2.2.8
> diff -u -r1.2.2.8 au1000_eth.h
> --- au1000_eth.h	3 Mar 2003 06:40:30 -0000	1.2.2.8
> +++ au1000_eth.h	28 Mar 2003 19:05:48 -0000
> @@ -36,7 +36,7 @@
>  #define MAX_BUF_SIZE 2048
>  
>  #define ETH_TX_TIMEOUT HZ/4
> -#define MAC_MIN_PKT_SIZE 64
> +#define MAC_MIN_PKT_SIZE 60
>  
>  #if defined(CONFIG_MIPS_PB1000) || defined(CONFIG_MIPS_PB1500) || defined(CONFIG_MIPS_PB1100) || defined(CONFIG_MIPS_DB1000) || defined(CONFIG_MIPS_DB1100) || defined(CONFIG_MIPS_DB1500)
>  #define PHY_ADDRESS              0

Re: Au1000 ethernet patch

[Ralf Baechle]

On Fri, Mar 28, 2003 at 02:37:48PM -0800, Pete Popov wrote:

> On Fri, 2003-03-28 at 11:14, Hartvig Ekner wrote:
> > The following patch fixes an error where ethernet minimum packets are 4 bytes too long. This caused certain
> > devices not to respond to ARP requests (which is a bug on their side as well, but.....).
> 
> 
> Thanks, I'll apply it later tonight.

<asm/if_ether.h> already defines the constant ETH_ZLEN for this purpose.

  Ralf

Re: Au1000 ethernet patch

[Pete Popov]

On Fri, 2003-03-28 at 15:41, Ralf Baechle wrote:
> On Fri, Mar 28, 2003 at 02:37:48PM -0800, Pete Popov wrote:
> 
> > On Fri, 2003-03-28 at 11:14, Hartvig Ekner wrote:
> > > The following patch fixes an error where ethernet minimum packets are 4 bytes too long. This caused certain
> > > devices not to respond to ARP requests (which is a bug on their side as well, but.....).
> > 
> > 
> > Thanks, I'll apply it later tonight.
> 
> <asm/if_ether.h> already defines the constant ETH_ZLEN for this purpose.

Great, thanks. I'll make the correction.

Pete