From: Manfred Spraul <manfred@colorfullife.com>
To: Shawn Starr <spstarr@sh0n.net>
Cc: Narayan Desai <desai@mcs.anl.gov>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.66-bk5 spinlock warnings/errors - Specifically ide-io:109 spinlock notice
Date: Thu, 03 Apr 2003 07:48:42 +0200 [thread overview]
Message-ID: <3E8BCB3A.8080806@colorfullife.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
Shawn wrote:
>>List: linux-kernel
>>Subject: 2.5.66-bk5 spinlock warnings/errors
>From: Narayan Desai <desai () mcs ! anl ! gov>
>>Date: 2003-04-02 4:01:02
>
>>hda: dma_timer_expiry: dma status == 0x24
>>drivers/ide/ide-io.c:109: spin_lock(drivers/ide/ide.c:c037abe8) already
>>locked by drivers/ide/ide-io.c/948 drivers/ide/ide-io.c:990:
>>spin_unlock(drivers/ide/ide.c:c037abe8) not locked
>>hda: lost interrupt
>>hda: dma_intr: bad DMA status (dma_stat=30)
>>hda: dma_intr: status=0x50 { DriveReady SeekComplete }
>
>I had this problem last night while making a huge debian package (tar.bz2
>stage). It occured once.
>
>
The attached patch should fix the problem:
the dma_timer_expiry handler calls HWGROUP(drive)->handler in the wrong
context. Instead of calling ->handler directly, the ->expiry handler
must inform the caller that ->handler must be called, and then the
caller must do some setup before calling ->handler.
--
Manfred
[-- Attachment #2: patch-ide-expiry --]
[-- Type: text/plain, Size: 1618 bytes --]
// $Header$
// Kernel Version:
// VERSION = 2
// PATCHLEVEL = 5
// SUBLEVEL = 66
// EXTRAVERSION =
--- 2.5/include/linux/ide.h 2003-03-25 17:49:52.000000000 +0100
+++ build-2.5/include/linux/ide.h 2003-03-30 10:04:08.000000000 +0200
@@ -1043,6 +1043,8 @@
typedef ide_startstop_t (ide_handler_t)(ide_drive_t *);
typedef ide_startstop_t (ide_post_handler_t)(ide_drive_t *);
typedef int (ide_expiry_t)(ide_drive_t *);
+#define EXPIRY_ABORT (0)
+#define EXPIRY_CALLHANDLER (-1)
typedef struct hwgroup_s {
/* irq handler, if active */
--- 2.5/drivers/ide/ide-io.c 2003-03-25 17:49:40.000000000 +0100
+++ build-2.5/drivers/ide/ide-io.c 2003-03-30 10:05:28.000000000 +0200
@@ -973,7 +973,7 @@
}
if ((expiry = hwgroup->expiry) != NULL) {
/* continue */
- if ((wait = expiry(drive)) != 0) {
+ if ((wait = expiry(drive)) > 0) {
/* reset timer */
hwgroup->timer.expires = jiffies + wait;
add_timer(&hwgroup->timer);
@@ -998,7 +998,7 @@
/* local CPU only,
* as if we were handling an interrupt */
local_irq_disable();
- if (hwgroup->poll_timeout != 0) {
+ if (hwgroup->poll_timeout != 0 || wait == EXPIRY_CALLHANDLER) {
startstop = handler(drive);
} else if (drive_is_ready(drive)) {
if (drive->waiting_for_dma)
--- 2.5/drivers/ide/ide-dma.c 2003-03-25 17:49:40.000000000 +0100
+++ build-2.5/drivers/ide/ide-dma.c 2003-03-30 10:05:54.000000000 +0200
@@ -483,9 +483,9 @@
return WAIT_CMD;
if (dma_stat & 4) /* Got an Interrupt */
- HWGROUP(drive)->handler(drive);
+ return EXPIRY_CALLHANDLER;
- return 0;
+ return EXPIRY_ABORT;
}
/**
next reply other threads:[~2003-04-03 5:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 5:48 Manfred Spraul [this message]
2003-04-03 16:36 ` 2.5.66-bk5 spinlock warnings/errors - Specifically ide-io:109 spinlock notice Shawn Starr
2003-04-16 16:28 ` Shawn Starr
2003-04-16 16:59 ` Manfred Spraul
-- strict thread matches above, loose matches on Subject: below --
2003-04-02 19:29 Shawn Starr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E8BCB3A.8080806@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=desai@mcs.anl.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=spstarr@sh0n.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.