From: Manfred Spraul <manfred@colorfullife.com>
To: Shawn Starr <spstarr@sh0n.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.66-bk5 spinlock warnings/errors - Specifically ide-io:109 spinlock notice
Date: Wed, 16 Apr 2003 18:59:18 +0200 [thread overview]
Message-ID: <3E9D8BE6.1020006@colorfullife.com> (raw)
In-Reply-To: <003b01c30435$27ac0ab0$030aa8c0@unknown>
Shawn Starr wrote:
>I'm going to apply this and see what happens, unless it was already added to
>.67-bk latest?
>
>
Alan included it into the -ac kernels, I guess he will forward it to Linus.
>>--- 2.5/drivers/ide/ide-io.c 2003-03-25 17:49:40.000000000 +0100
>>+++ build-2.5/drivers/ide/ide-io.c 2003-03-30 10:05:28.000000000 +0200
>>@@ -973,7 +973,7 @@
>>
>>
>> }
>>
+ wait = 0;
>> if ((expiry = hwgroup->expiry) != NULL) {
>> /* continue */
>>- if ((wait = expiry(drive)) != 0) {
>>+ if ((wait = expiry(drive)) > 0) {
>> /* reset timer */
>> hwgroup->timer.expires = jiffies + wait;
>> add_timer(&hwgroup->timer);
>>
This change was missing in my patch: wait was used without initialization.
--
Manfred
next prev parent reply other threads:[~2003-04-16 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 5:48 2.5.66-bk5 spinlock warnings/errors - Specifically ide-io:109 spinlock notice Manfred Spraul
2003-04-03 16:36 ` Shawn Starr
2003-04-16 16:28 ` Shawn Starr
2003-04-16 16:59 ` Manfred Spraul [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-04-02 19:29 Shawn Starr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E9D8BE6.1020006@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spstarr@sh0n.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.