* [BK PATCH] irqreturn_t unsignedness
@ 2003-04-26 4:17 Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2003-04-26 4:17 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: irq-return-2.5.txt --]
[-- Type: text/plain, Size: 788 bytes --]
Linus, please do a
bk pull bk://kernel.bkbits.net/jgarzik/irq-return-2.5
This will update the following files:
include/linux/interrupt.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
through these ChangeSets:
<jgarzik@redhat.com> (03/04/25 1.1252)
s/int/unsigned int/ for irqreturn_t definition.
Pragmatic change. Would prefer to make it now rather than later.
Though sign-extension problems are unlikely, I prefer 'unsigned int'
because it occasionally generates better code, and 'int' occasionally
generates sub-optimal code (because the compiler cannot rule out
negative values during optimization).
Better still would be to indicate the variable's true range
via _Bool: zero, and non-zero, but I did not make that change
here.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-04-26 4:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-04-26 4:17 [BK PATCH] irqreturn_t unsignedness Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.