2.5.69-bk19 "make" messages much less informative

2.5.69-bk19 "make" messages much less informative

[Adam J. Richter]

	2.5.69-bk19 dumbs down the messages from make into a format
like so:

  CC      arch/i386/kernel/doublefault.o
  CC      arch/i386/kernel/acpi/boot.o
  CC      arch/i386/kernel/acpi/sleep.o
  AS      arch/i386/kernel/acpi/wakeup.o
  LD      arch/i386/kernel/acpi/built-in.o
  CC      arch/i386/kernel/cpu/common.o

	This is much less informative than seeing the actual CC commands.
It impedes people doing their own debugging and people helping others
remotely (because they want to know exactly what options were passed
to gcc).

	Also, I used to be able to copy and paste the gcc command
for compiling a particular file when I'm trying to get rid of compiler
errors.  As a result, this change slightly reduces the amount or quality
of software that I write in a given amount of time.

	Please revert it.

Adam J. Richter     __     ______________   575 Oroville Road
adam@yggdrasil.com     \ /                  Miplitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."

Re: 2.5.69-bk19 "make" messages much less informative

[John Levon]

On Mon, May 26, 2003 at 03:23:05PM -0700, Adam J. Richter wrote:

> 	2.5.69-bk19 dumbs down the messages from make into a format

You can use make V=1 (I hope) to get the proper behaviour back

> 	This is much less informative than seeing the actual CC commands.

I completely agree. A step backwards :( V=0 is certainly useful but it
shouldn't be the default. You can't force people to pay attention to
warnings, only encourage them...

john

Re: 2.5.69-bk19 "make" messages much less informative

[Carl-Daniel Hailfinger]

John Levon wrote:
> On Mon, May 26, 2003 at 03:23:05PM -0700, Adam J. Richter wrote:
> 
> 
>>	2.5.69-bk19 dumbs down the messages from make into a format
> 
> 
> You can use make V=1 (I hope) to get the proper behaviour back
> 
> 
>>	This is much less informative than seeing the actual CC commands.
> 
> 
> I completely agree. A step backwards :( V=0 is certainly useful but it
> shouldn't be the default. You can't force people to pay attention to
> warnings, only encourage them...

If something stands out clearly, people tend to notice it. Assuming only
one person gets annoyed enough to submit fixes for the warnings, this is
a net win.
V=0 still works, only the default was changed.


Regards,
Carl-Daniel
-- 
http://www.hailfinger.org/

Re: 2.5.69-bk19 "make" messages much less informative

[Adam J. Richter]

Carl-Daniel Hailfinger wrote:
>If something stands out clearly, people tend to notice it. Assuming only
>one person gets annoyed enough to submit fixes for the warnings, this is
>a net win.
>V=0 still works, only the default was changed.

	I think the productivity that I would lose from such a build
environment would exceed the fixing of one compiler warning within
a couple of days, perhaps even sooner, and I am only one developer.

	Many thanks to John Levon for pointing out that V=1 still
works.  Here is a proposed patch, which I have already committed
to my tree.

Adam J. Richter     __     ______________   575 Oroville Road
adam@yggdrasil.com     \ /                  Miplitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."


--- linux-2.5.69-bk19/Makefile	2003-05-26 12:26:26.000000000 -0700
+++ linux/Makefile	2003-05-26 18:00:31.000000000 -0700
@@ -107,15 +107,13 @@
 # If it is set to "silent_", nothing wil be printed at all, since
 # the variable $(silent_cmd_cc_o_c) doesn't exist.
 
-# To put more focus on warnings, less verbose as default
-
 ifdef V
   ifeq ("$(origin V)", "command line")
     KBUILD_VERBOSE = $(V)
   endif
 endif
 ifndef KBUILD_VERBOSE
-  KBUILD_VERBOSE = 0 
+  KBUILD_VERBOSE = 1
 endif
 
 ifdef C

Re: 2.5.69-bk19 "make" messages much less informative

[Sam Ravnborg]

On Mon, May 26, 2003 at 03:23:05PM -0700, Adam J. Richter wrote:
> 	Also, I used to be able to copy and paste the gcc command
> for compiling a particular file when I'm trying to get rid of compiler
> errors.

The easy way to handle this is actually to ask kbuild to compile the
file in question.
Example:
$ make arch/i386/kernel/acpi/boot.o

This wil perfectly fine compile boot.c - no need to hassle with copying
long gcc command lines.

A shorthand exists for compiling all built-in files in a directory
as well. Very useful when working on a subsystem.
Assuming ext2 is built-in try out:
$ make fs/ext2/

And as already pointed out, the easy way to enable to verbose
output is to use:
$ make V=1

	Sam