[PATCH] nbd.c compile warning

[PATCH] nbd.c compile warning

[Lou Langholtz]

Do you have large block device support turned on or off in your kernel 
build options? I believe this compile warning came as a result of 
compiling without CONFIG_LBD - I hadn't tried building that way and 
would then have missed this problem. Just typecasting the result as your 
patch does should work correctly either way though. I'll make sure to 
pull it into my NBD sources but you will need to get Andrew Morton or 
Paul Clements to pick up the patch for it to move into the kernel distro 
stream. I've CC'd them on this message to help expedite this. Thanks!

Re: [PATCH] nbd.c compile warning

[Shane Shrybman]

On Sat, 2003-07-12 at 13:04, Lou Langholtz wrote:
> Do you have large block device support turned on or off in your kernel 
> build options? I believe this compile warning came as a result of 

# CONFIG_LBD is not set

> compiling without CONFIG_LBD - I hadn't tried building that way and 
> would then have missed this problem. Just typecasting the result as your 
> patch does should work correctly either way though. I'll make sure to 
> pull it into my NBD sources but you will need to get Andrew Morton or 
> Paul Clements to pick up the patch for it to move into the kernel distro 
> stream. I've CC'd them on this message to help expedite this. Thanks!
> 

Mr. Clements was cc'd on the original email as well. Thanks for looking
at the patch.

Regards,

shane

[PATCH] nbd.c compile warning

[Shane Shrybman]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

Here is a patch to fix a compile warning from nbd.c. It has been compile
tested, ( I don't actually use nbd, yet). I have included the patch as
an attachment in case it gets mangled.

--- linux-2.5.75-mm1/drivers/block/nbd.c.orig   Sat Jul 12 09:23:45 2003
+++ linux-2.5.75-mm1/drivers/block/nbd.c        Sat Jul 12 09:45:06 2003
@@ -261,7 +261,7 @@
        dprintk(DBG_TX, "%s: request %p: sending control
(%s@%llu,%luB)\n",
                        lo->disk->disk_name, req,
                        nbdcmd_to_ascii(nbd_cmd(req)),
-                       req->sector << 9, req->nr_sectors << 9);
+                       (unsigned long long)req->sector << 9,
req->nr_sectors << 9);
        result = sock_xmit(sock, 1, &request, sizeof(request),
                        (nbd_cmd(req) == NBD_CMD_WRITE)? MSG_MORE: 0);
        if (result <= 0) {


Regards,

shane

[-- Attachment #2: nbd.compile.warning.diff --]
[-- Type: text/x-diff, Size: 531 bytes --]

--- linux-2.5.75-mm1/drivers/block/nbd.c.orig	Sat Jul 12 09:23:45 2003
+++ linux-2.5.75-mm1/drivers/block/nbd.c	Sat Jul 12 09:45:06 2003
@@ -261,7 +261,7 @@
 	dprintk(DBG_TX, "%s: request %p: sending control (%s@%llu,%luB)\n",
 			lo->disk->disk_name, req,
 			nbdcmd_to_ascii(nbd_cmd(req)),
-			req->sector << 9, req->nr_sectors << 9);
+			(unsigned long long)req->sector << 9, req->nr_sectors << 9);
 	result = sock_xmit(sock, 1, &request, sizeof(request),
 			(nbd_cmd(req) == NBD_CMD_WRITE)? MSG_MORE: 0);
 	if (result <= 0) {

Re: [PATCH] nbd.c compile warning

[Paul Clements]

On 12 Jul 2003, Shane Shrybman wrote:

> Here is a patch to fix a compile warning from nbd.c. It has been compile
> tested, ( I don't actually use nbd, yet). I have included the patch as
> an attachment in case it gets mangled.
> 
> --- linux-2.5.75-mm1/drivers/block/nbd.c.orig   Sat Jul 12 09:23:45 2003
> +++ linux-2.5.75-mm1/drivers/block/nbd.c        Sat Jul 12 09:45:06 2003
> @@ -261,7 +261,7 @@
>         dprintk(DBG_TX, "%s: request %p: sending control
> (%s@%llu,%luB)\n",
>                         lo->disk->disk_name, req,
>                         nbdcmd_to_ascii(nbd_cmd(req)),
> -                       req->sector << 9, req->nr_sectors << 9);
> +                       (unsigned long long)req->sector << 9,
> req->nr_sectors << 9);
>         result = sock_xmit(sock, 1, &request, sizeof(request),
>                         (nbd_cmd(req) == NBD_CMD_WRITE)? MSG_MORE: 0);
>         if (result <= 0) {
> 

Thanks, I'll send a patch on to Andrew Morton shortly.

--
Paul