* Re: [PATCH] missing io_apic.h inclusions
[not found] <200308210912.h7L9CUtW029374@hera.kernel.org>
@ 2003-08-21 14:22 ` Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2003-08-21 14:22 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: akpm
Linux Kernel Mailing List wrote:
> diff -Nru a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
> --- a/arch/i386/kernel/acpi/boot.c Thu Aug 21 02:12:34 2003
> +++ b/arch/i386/kernel/acpi/boot.c Thu Aug 21 02:12:34 2003
> @@ -34,6 +34,7 @@
> #if defined (CONFIG_X86_LOCAL_APIC)
> #include <mach_apic.h>
> #include <mach_mpparse.h>
> +#include <asm/io_apic.h>
> #endif
>
> #define PREFIX "ACPI: "
> diff -Nru a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
> --- a/arch/i386/kernel/setup.c Thu Aug 21 02:12:34 2003
> +++ b/arch/i386/kernel/setup.c Thu Aug 21 02:12:34 2003
> @@ -43,6 +43,7 @@
> #include <asm/setup.h>
> #include <asm/arch_hooks.h>
> #include <asm/sections.h>
> +#include <asm/io_apic.h>
> #include "setup_arch_pre.h"
> #include "mach_resources.h"
Well, the first change looks pretty wrong just given the config option.
And, too, this was the false "build fix". The correct build fix was
committed, and this patch was not needed at all. I'll grant that the
patch to setup.c does make sense, though, even if it's not strictly needed.
Jeff
^ permalink raw reply [flat|nested] only message in thread