From: Timothy Miller <miller@techsource.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: torvalds@osdl.org, Patrick Mochel <mochel@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you?
Date: Fri, 22 Aug 2003 18:04:52 -0400 [thread overview]
Message-ID: <3F469384.5090909@techsource.com> (raw)
In-Reply-To: 20030822210800.GA4403@elf.ucw.cz
Pavel Machek wrote:
> static int __init resume_setup(char *str)
> {
> - strncpy( resume_file, str, 255 );
> + if (strlen(str))
> + strncpy(resume_file, str, 255);
> return 1;
> }
Silly me, but if you want to check to be sure a string has a length
greater than zero, wouldn't it be faster to just check to be sure that
the first byte is not zero?
Think about how much work it does if the string is 100 characters long
when all you want to do is determine that it's non-zero.
prev parent reply other threads:[~2003-08-22 21:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-22 21:08 [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Pavel Machek
2003-08-22 21:25 ` Patrick Mochel
2003-08-22 21:53 ` Pavel Machek
2003-08-22 22:05 ` Patrick Mochel
2003-08-23 1:03 ` Nigel Cunningham
2003-08-23 16:22 ` Benjamin Herrenschmidt
2003-08-25 19:05 ` [PM] powering down special devices Patrick Mochel
2003-08-25 19:53 ` Benjamin Herrenschmidt
2003-08-25 9:52 ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Pavel Machek
2003-08-22 22:10 ` Pavel Machek
2003-08-22 22:13 ` Patrick Mochel
2003-08-22 22:17 ` Patrick Mochel
2003-08-22 22:36 ` Pavel Machek
2003-08-23 10:47 ` Russell King
2003-08-24 11:54 ` Russell King
2003-08-26 15:39 ` [PM] Config Options Patrick Mochel
2003-08-24 12:08 ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Russell King
2003-08-25 15:47 ` Patrick Mochel
2003-08-25 16:27 ` Russell King
2003-08-25 16:57 ` Matt Porter
2003-08-25 17:14 ` Russell King
2003-08-25 17:34 ` Matt Porter
2003-08-28 15:38 ` Platform Devices Patrick Mochel
2003-09-01 12:02 ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Pavel Machek
2003-09-02 17:41 ` Jens Axboe
2003-09-09 20:19 ` Benjamin Herrenschmidt
2003-09-09 20:24 ` Jens Axboe
2003-09-09 21:43 ` Patrick Mochel
2003-09-09 22:54 ` Pavel Machek
2003-09-09 23:07 ` Patrick Mochel
2003-09-09 23:07 ` [PM] Passing suspend level down to drivers Pavel Machek
2003-09-09 23:23 ` Patrick Mochel
2003-09-10 0:06 ` Pavel Machek
2003-09-10 6:12 ` Stephen Rothwell
2003-09-10 11:48 ` Alan Cox
2003-09-09 23:15 ` [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? Alan Cox
2003-09-09 22:56 ` Pavel Machek
2003-08-25 17:16 ` Russell King
2003-08-22 22:04 ` Timothy Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F469384.5090909@techsource.com \
--to=miller@techsource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.