[PATCH]: fix ipt_MASQUERADE in latest -bk

[PATCH]: fix ipt_MASQUERADE in latest -bk

[Patrick McHardy]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

Hi Harald,
this change broke masquerading, key.oif is uninitialized and routing
lookups fail:

[NETFILTER]: Fix masquerade routing check, backport to 2.4 by 
kurd@cp.rtfm.se

This patch fixes it.

Best regards,
Patrick

[-- Attachment #2: ipt_MASQUERADE-oif.diff --]
[-- Type: text/plain, Size: 462 bytes --]

===== net/ipv4/netfilter/ipt_MASQUERADE.c 1.6 vs edited =====
--- 1.6/net/ipv4/netfilter/ipt_MASQUERADE.c	Tue Aug 12 11:30:12 2003
+++ edited/net/ipv4/netfilter/ipt_MASQUERADE.c	Fri Aug 29 02:09:24 2003
@@ -87,6 +87,7 @@
 	key.dst = (*pskb)->nh.iph->daddr;
 	key.src = 0; /* Unknown: that's what we're trying to establish */
 	key.tos = RT_TOS((*pskb)->nh.iph->tos)|RTO_CONN;
+	key.oif = 0;
 #ifdef CONFIG_IP_ROUTE_FWMARK
 	key.fwmark = (*pskb)->nfmark;
 #endif

Re: [PATCH]: fix ipt_MASQUERADE in latest -bk

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Fri, Aug 29, 2003 at 02:10:26AM +0200, Patrick McHardy wrote:
> Hi Harald,
> this change broke masquerading, key.oif is uninitialized and routing
> lookups fail:

thanks, I'll submit this today.

> Best regards,
> Patrick

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]