All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Marcelo Tosatti <marcelo@parcelfarce.linux.theplanet.co.uk>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
	"David S. Miller" <davem@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix ifdown/ifup bug
Date: Fri, 12 Sep 2003 17:11:50 -0400	[thread overview]
Message-ID: <3F623696.1080703@pobox.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

Marcelo,

If you haven't gotten this patch from somebody else, please make sure 
this is applied.  It fixes a bug I introduced in -pre3 when moving some 
helpers from tg3 to netdevice.h.

	Jeff



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 510 bytes --]

diff -Nru a/net/core/dev.c b/net/core/dev.c
--- a/net/core/dev.c	Fri Sep 12 17:10:03 2003
+++ b/net/core/dev.c	Fri Sep 12 17:10:03 2003
@@ -851,7 +851,11 @@
 	 * engine, but this requires more changes in devices. */
 
 	smp_mb__after_clear_bit(); /* Commit netif_running(). */
-	netif_poll_disable(dev);
+	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
+		/* No hurry. */
+		current->state = TASK_INTERRUPTIBLE;
+		schedule_timeout(1);
+	}
 
 	/*
 	 *	Call the device specific close. This cannot fail.

             reply	other threads:[~2003-09-12 21:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-12 21:11 Jeff Garzik [this message]
2003-09-12 23:30 ` [PATCH] fix ifdown/ifup bug Fedor Karpelevitch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F623696.1080703@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=marcelo@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.