* [PATCH] fix ifdown/ifup bug
@ 2003-09-12 21:11 Jeff Garzik
2003-09-12 23:30 ` Fedor Karpelevitch
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2003-09-12 21:11 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Marcelo Tosatti, David S. Miller, LKML
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
Marcelo,
If you haven't gotten this patch from somebody else, please make sure
this is applied. It fixes a bug I introduced in -pre3 when moving some
helpers from tg3 to netdevice.h.
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 510 bytes --]
diff -Nru a/net/core/dev.c b/net/core/dev.c
--- a/net/core/dev.c Fri Sep 12 17:10:03 2003
+++ b/net/core/dev.c Fri Sep 12 17:10:03 2003
@@ -851,7 +851,11 @@
* engine, but this requires more changes in devices. */
smp_mb__after_clear_bit(); /* Commit netif_running(). */
- netif_poll_disable(dev);
+ while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
+ /* No hurry. */
+ current->state = TASK_INTERRUPTIBLE;
+ schedule_timeout(1);
+ }
/*
* Call the device specific close. This cannot fail.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix ifdown/ifup bug
2003-09-12 21:11 [PATCH] fix ifdown/ifup bug Jeff Garzik
@ 2003-09-12 23:30 ` Fedor Karpelevitch
0 siblings, 0 replies; 2+ messages in thread
From: Fedor Karpelevitch @ 2003-09-12 23:30 UTC (permalink / raw)
To: Jeff Garzik, Marcelo Tosatti; +Cc: Marcelo Tosatti, David S. Miller, LKML
Jeff Garzik wrote:
> Marcelo,
>
> If you haven't gotten this patch from somebody else, please make
> sure this is applied. It fixes a bug I introduced in -pre3 when
> moving some helpers from tg3 to netdevice.h.
>
FYI it does not seem to fix this issue for me.
Fedor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-13 6:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-12 21:11 [PATCH] fix ifdown/ifup bug Jeff Garzik
2003-09-12 23:30 ` Fedor Karpelevitch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.