* 2.6.0-test5 : Bug in include/linux/input.h ?
@ 2003-09-16 19:42 Remi Colinet
2003-09-16 20:25 ` Andries Brouwer
0 siblings, 1 reply; 2+ messages in thread
From: Remi Colinet @ 2003-09-16 19:42 UTC (permalink / raw)
To: Kernel List
Hi,
While reading the input code, I found the following error in
drivers/linux/input.h :
--- include/linux/input.h 2003-08-23 01:54:59.000000000 +0200
+++ include/linux/input.h.mod 2003-09-16 21:38:10.000000000 +0200
@@ -751,7 +751,7 @@
#define LONG(x) ((x)/BITS_PER_LONG)
#define INPUT_KEYCODE(dev, scancode) ((dev->keycodesize == 1) ?
((u8*)dev->keycode)[scancode] : \
- ((dev->keycodesize == 1) ? ((u16*)dev->keycode)[scancode] :
(((u32*)dev->keycode)[scancode])))
+ ((dev->keycodesize == 2) ? ((u16*)dev->keycode)[scancode] :
(((u32*)dev->keycode)[scancode])))
#define init_input_dev(dev) do { INIT_LIST_HEAD(&((dev)->h_list));
INIT_LIST_HEAD(&((dev)->node)); } while (0)
Remi
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: 2.6.0-test5 : Bug in include/linux/input.h ?
2003-09-16 19:42 2.6.0-test5 : Bug in include/linux/input.h ? Remi Colinet
@ 2003-09-16 20:25 ` Andries Brouwer
0 siblings, 0 replies; 2+ messages in thread
From: Andries Brouwer @ 2003-09-16 20:25 UTC (permalink / raw)
To: Remi Colinet; +Cc: Kernel List
On Tue, Sep 16, 2003 at 09:42:38PM +0200, Remi Colinet wrote:
> While reading the input code, I found the following error in
> drivers/linux/input.h :
>
> #define INPUT_KEYCODE(dev, scancode) ((dev->keycodesize == 1) ?
> ((u8*)dev->keycode)[scancode] : \
> - ((dev->keycodesize == 1) ? ((u16*)dev->keycode)[scancode] :
> (((u32*)dev->keycode)[scancode])))
> + ((dev->keycodesize == 2) ? ((u16*)dev->keycode)[scancode] :
> (((u32*)dev->keycode)[scancode])))
Yes.
(But we only use 1 if I am not mistaken, so no kernel behaviour changes.)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-16 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-16 19:42 2.6.0-test5 : Bug in include/linux/input.h ? Remi Colinet
2003-09-16 20:25 ` Andries Brouwer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.