[PATCH] ip6tables-save and udp port range

[PATCH] ip6tables-save and udp port range

[Thomas Woerner]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]


Hello,


ip6tables-save is not saving an udp port range if one of the ports is 
0x0 or 0xFFFF. This is aleady fixed in the ipv4 version.

I have attached the patch.


Thanks in advance
Thomas Woerner


-- 
Thomas Woerner, Software Engineer      Phone: +49-711-96437-0
Red Hat GmbH                           Fax  : +49-711-96437-111
Hauptstaetterstr. 58                   Email: twoerner@redhat.com
D-70178 Stuttgart                      Web  : http://www.redhat.de/

[-- Attachment #2: iptables-1.2.8-save_ports.patch --]
[-- Type: text/plain, Size: 676 bytes --]

--- iptables-1.2.8/extensions/libip6t_udp.c.save_ports	2003-09-17 16:11:40.000000000 +0200
+++ iptables-1.2.8/extensions/libip6t_udp.c	2003-09-17 16:27:17.000000000 +0200
@@ -205,7 +205,7 @@
 	const struct ip6t_udp *udpinfo = (struct ip6t_udp *)match->data;
 
 	if (udpinfo->spts[0] != 0
-	    && udpinfo->spts[1] != 0xFFFF) {
+	    || udpinfo->spts[1] != 0xFFFF) {
 		if (udpinfo->invflags & IP6T_UDP_INV_SRCPT)
 			printf("! ");
 		if (udpinfo->spts[0]
@@ -219,7 +219,7 @@
 	}
 
 	if (udpinfo->dpts[0] != 0
-	    && udpinfo->dpts[1] != 0xFFFF) {
+	    || udpinfo->dpts[1] != 0xFFFF) {
 		if (udpinfo->invflags & IP6T_UDP_INV_DSTPT)
 			printf("! ");
 		if (udpinfo->dpts[0]

Re: [PATCH] ip6tables-save and udp port range

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

On Tue, Sep 23, 2003 at 11:21:04AM +0200, Thomas Woerner wrote:

> ip6tables-save is not saving an udp port range if one of the ports is 
> 0x0 or 0xFFFF. This is aleady fixed in the ipv4 version.

thanks, patch applied.

> Thanks in advance
> Thomas Woerner

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]