From: Brian Gerst <bgerst@quark.didntduck.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] i386 do_machine_check() is redundant.
Date: Sun, 28 Sep 2003 12:29:03 -0400 [thread overview]
Message-ID: <3F770C4F.5020407@quark.didntduck.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 72 bytes --]
Use machine_check_vector in the entry code instead.
--
Brian Gerst
[-- Attachment #2: mce-1 --]
[-- Type: text/plain, Size: 1072 bytes --]
diff -urN linux-2.6.0-test6/arch/i386/kernel/cpu/mcheck/mce.c linux/arch/i386/kernel/cpu/mcheck/mce.c
--- linux-2.6.0-test6/arch/i386/kernel/cpu/mcheck/mce.c 2003-07-27 13:06:29.000000000 -0400
+++ linux/arch/i386/kernel/cpu/mcheck/mce.c 2003-09-28 12:23:16.267949368 -0400
@@ -26,11 +26,6 @@
/* Call the installed machine check handler for this CPU setup. */
void (*machine_check_vector)(struct pt_regs *, long error_code) = unexpected_machine_check;
-asmlinkage void do_machine_check(struct pt_regs * regs, long error_code)
-{
- machine_check_vector(regs, error_code);
-}
-
/* This has to be run for each processor */
void __init mcheck_init(struct cpuinfo_x86 *c)
{
diff -urN linux-2.6.0-test6/arch/i386/kernel/entry.S linux/arch/i386/kernel/entry.S
--- linux-2.6.0-test6/arch/i386/kernel/entry.S 2003-09-28 10:20:13.981227536 -0400
+++ linux/arch/i386/kernel/entry.S 2003-09-28 12:23:16.268949216 -0400
@@ -595,7 +595,7 @@
#ifdef CONFIG_X86_MCE
ENTRY(machine_check)
pushl $0
- pushl $do_machine_check
+ pushl machine_check_vector
jmp error_code
#endif
next reply other threads:[~2003-09-28 16:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-28 16:29 Brian Gerst [this message]
2003-09-28 18:24 ` [PATCH] i386 do_machine_check() is redundant Linus Torvalds
2003-09-28 18:30 ` Brian Gerst
2003-09-28 18:34 ` Linus Torvalds
2003-09-28 18:44 ` Brian Gerst
2003-09-28 19:04 ` Arjan van de Ven
2003-09-29 18:46 ` Linus Torvalds
2003-09-29 19:23 ` Jeff Garzik
2003-09-29 19:54 ` -mregparm=3 (was " Valdis.Kletnieks
2003-09-30 8:28 ` Helge Hafting
2003-09-30 15:29 ` Valdis.Kletnieks
2003-09-30 15:48 ` Linus Torvalds
2003-09-29 20:20 ` Mikulas Patocka
2003-09-29 20:26 ` Daniel Jacobowitz
2003-09-29 21:36 ` Mikulas Patocka
2003-09-29 21:40 ` Daniel Jacobowitz
2003-09-29 21:43 ` Mikulas Patocka
2003-09-29 21:48 ` Jakub Jelinek
2003-09-30 0:24 ` Jamie Lokier
2003-09-30 4:49 ` Valdis.Kletnieks
2003-09-30 4:55 ` Robert Love
2003-09-30 14:37 ` Valdis.Kletnieks
2003-09-30 15:48 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F770C4F.5020407@quark.didntduck.org \
--to=bgerst@quark.didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.