From: Felipe W Damasio <felipewd@terra.com.br>
To: dwmw2@redhat.com
Cc: linux-mtd@lists.infradead.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Memory leak in mtd/chips/cfi_cmdset_0020
Date: Mon, 06 Oct 2003 11:45:30 -0300 [thread overview]
Message-ID: <3F81800A.5000500@terra.com.br> (raw)
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
Hi David,
Patch against 2.6.0-test6.
- Frees a previous allocated kmalloced variable before returning NULL;
Found by smatch.
Please consider applying,
Felipe
[-- Attachment #2: cfi_cmdset_0020-leak.patch --]
[-- Type: text/plain, Size: 385 bytes --]
--- linux-2.6.0-test6/drivers/mtd/chips/cfi_cmdset_0020.c.orig 2003-10-06 11:37:31.000000000 -0300
+++ linux-2.6.0-test6/drivers/mtd/chips/cfi_cmdset_0020.c 2003-10-06 11:37:50.000000000 -0300
@@ -208,6 +208,7 @@
if (!mtd->eraseregions) {
printk(KERN_ERR "Failed to allocate memory for MTD erase region info\n");
kfree(cfi->cmdset_priv);
+ kfree(mtd);
return NULL;
}
WARNING: multiple messages have this Message-ID (diff)
From: Felipe W Damasio <felipewd@terra.com.br>
To: dwmw2@redhat.com
Cc: mtd@infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Memory leak in mtd/chips/cfi_cmdset_0020
Date: Mon, 06 Oct 2003 11:45:30 -0300 [thread overview]
Message-ID: <3F81800A.5000500@terra.com.br> (raw)
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
Hi David,
Patch against 2.6.0-test6.
- Frees a previous allocated kmalloced variable before returning NULL;
Found by smatch.
Please consider applying,
Felipe
[-- Attachment #2: cfi_cmdset_0020-leak.patch --]
[-- Type: text/plain, Size: 385 bytes --]
--- linux-2.6.0-test6/drivers/mtd/chips/cfi_cmdset_0020.c.orig 2003-10-06 11:37:31.000000000 -0300
+++ linux-2.6.0-test6/drivers/mtd/chips/cfi_cmdset_0020.c 2003-10-06 11:37:50.000000000 -0300
@@ -208,6 +208,7 @@
if (!mtd->eraseregions) {
printk(KERN_ERR "Failed to allocate memory for MTD erase region info\n");
kfree(cfi->cmdset_priv);
+ kfree(mtd);
return NULL;
}
next reply other threads:[~2003-10-06 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 14:45 Felipe W Damasio [this message]
2003-10-06 14:45 ` [PATCH] Memory leak in mtd/chips/cfi_cmdset_0020 Felipe W Damasio
2003-10-06 14:46 ` David Woodhouse
2003-10-06 14:46 ` David Woodhouse
2003-10-06 14:54 ` Felipe W Damasio
2003-10-06 14:54 ` Felipe W Damasio
2003-10-06 14:52 ` David Woodhouse
2003-10-06 14:52 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F81800A.5000500@terra.com.br \
--to=felipewd@terra.com.br \
--cc=dwmw2@redhat.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.