au88xo spin_lock and spin_unlock error

au88xo spin_lock and spin_unlock error

[Supphachoke Suntiwichaya]

Hi,
    I can't  compile ALSA-DRIVER 0.9.7b .

====
In file included from au8810_core.c:2:
au88x0_core.c: In function `vortex_adb_allocroute':
au88x0_core.c:1780: incompatible type for argument 1 of `_raw_spin_lock'
au88x0_core.c:1887: incompatible type for argument 1 of `_raw_spin_unlock'
make[2]: *** [au8810_core.o] Error 1
make[1]: *** [_modsubdir_au88x0] Error 2

====
I used kernel 2.4.22
http://www-ccrma.stanford.edu/planetccrma/software/system.html#kernel

MrChoke
-- 

Name : Supphachoke Suntiwichaya
Email : MrChoke@opentle.org
URL : http://jedi.links.nectec.or.th/mrchoke/
Distribution : Linux TLE 5.0 (Andaman)
OS : Linux 2.4.23-pre4-tv #2 อา. ก.ย. 14 16:58:21 ICT 2003 i686 GNU/Linux
Uptime :  10:25:00  up 6 days, 18:39,  1 user,  load average: 0.13, 0.15, 0.16




-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php

Re: au88xo spin_lock and spin_unlock error

[Supphachoke Suntiwichaya]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

Again
       Check my patch , it correct ?

MrChoke

Supphachoke Suntiwichaya wrote:

> Hi,
>    I can't  compile ALSA-DRIVER 0.9.7b .
>
> ====
> In file included from au8810_core.c:2:
> au88x0_core.c: In function `vortex_adb_allocroute':
> au88x0_core.c:1780: incompatible type for argument 1 of `_raw_spin_lock'
> au88x0_core.c:1887: incompatible type for argument 1 of 
> `_raw_spin_unlock'
> make[2]: *** [au8810_core.o] Error 1
> make[1]: *** [_modsubdir_au88x0] Error 2
>
> ====
> I used kernel 2.4.22
> http://www-ccrma.stanford.edu/planetccrma/software/system.html#kernel
>
> MrChoke



-- 

Name : Supphachoke Suntiwichaya
Email : MrChoke@opentle.org
URL : http://jedi.links.nectec.or.th/mrchoke/
Distribution : Linux TLE 5.0 (Andaman)
OS : Linux 2.4.23-pre4-tv #2 อา. ก.ย. 14 16:58:21 ICT 2003 i686 GNU/Linux
Uptime :  11:05:00  up 6 days, 19:19,  1 user,  load average: 0.38, 0.42, 0.27


[-- Attachment #2: alsa-driver-0.9.7b-spin.patch --]
[-- Type: text/plain, Size: 667 bytes --]

--- alsa-driver-0.9.7b/pci/au88x0/au88x0_core.c	2003-10-06 21:01:04.000000000 +0700
+++ alsa-driver-0.9.7b/pci/au88x0/au88x0_core.c-spin	2003-10-13 10:46:53.000000000 +0700
@@ -1777,7 +1777,7 @@
 	if ((nr_ch == 3) || ((dir == SNDRV_PCM_STREAM_CAPTURE)&&(nr_ch > 2)))
 		return -EBUSY;
 	
-	spin_lock(vortex->lock);
+	spin_lock(&vortex->lock);
 	if (dma >= 0) {
    		en = 0;
 		vortex_adb_checkinout(vortex, vortex->dma_adb[dma].resources, en, VORTEX_RESOURCE_DMA);
@@ -1884,7 +1884,7 @@
 		}
 	}
 	vortex->dma_adb[dma].nr_ch = nr_ch;
-	spin_unlock(vortex->lock);
+	spin_unlock(&vortex->lock);
 	
 #if 0
 	/* AC97 Codec channel setup. FIXME: this has no effect !! */

Re: au88xo spin_lock and spin_unlock error (please apply patch)

[Manuel Jander]

Hi

Yeah, its correct. I wonder how this bug sneaked in again, i have fixed
this at least 2 times before :(

Best Regards

Manuel Jander

On Mon, 2003-10-13 at 00:05, Supphachoke Suntiwichaya wrote:
> Again
>        Check my patch , it correct ?
> 
> MrChoke
> 
> Supphachoke Suntiwichaya wrote:
> 
> > Hi,
> >    I can't  compile ALSA-DRIVER 0.9.7b .
> >
> > ====
> > In file included from au8810_core.c:2:
> > au88x0_core.c: In function `vortex_adb_allocroute':
> > au88x0_core.c:1780: incompatible type for argument 1 of `_raw_spin_lock'
> > au88x0_core.c:1887: incompatible type for argument 1 of 
> > `_raw_spin_unlock'
> > make[2]: *** [au8810_core.o] Error 1
> > make[1]: *** [_modsubdir_au88x0] Error 2
> >
> > ====
> > I used kernel 2.4.22
> > http://www-ccrma.stanford.edu/planetccrma/software/system.html#kernel
> >
> > MrChoke
> 
> 



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php