All of lore.kernel.org
 help / color / mirror / Atom feed
* Compiler Problems in tlbex-r4k.S
@ 2003-10-23  9:33 ` Ralf Rösch
  0 siblings, 0 replies; 5+ messages in thread
From: Ralf Rösch @ 2003-10-23  9:33 UTC (permalink / raw)
  To: linux-mips

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

The latest update in tlbex-r4k.S (tag 2_4) produces
following compiler errors on my machine:

mipsel-linux-gcc -D__ASSEMBLY__ -D__KERNEL__ -I/build/linux-2.4.22-rthal5g-s
trom
boli/include -I /build/linux-2.4.22-rthal5g-stromboli/include/asm/gcc -G
0 -mno-
abicalls -fno-pic -pipe   -mcpu=r4600 -mips2 -Wa,--trap   -c -o tlbex-r4k.o
tlbe
x-r4k.S
tlbex-r4k.S: Assembler messages:
tlbex-r4k.S:179: Error: missing ')'
tlbex-r4k.S:179: Error: missing ')'
tlbex-r4k.S:179: Error: missing ')'
tlbex-r4k.S:179: Error: illegal operands `and'
tlbex-r4k.S:207: Error: missing ')'
tlbex-r4k.S:207: Error: missing ')'
tlbex-r4k.S:207: Error: missing ')'
tlbex-r4k.S:207: Error: illegal operands `and'
tlbex-r4k.S:243: Error: missing ')'
tlbex-r4k.S:243: Error: missing ')'
tlbex-r4k.S:243: Error: missing ')'
...

If I change the line 43 from:
#define PTE_PAGE_SIZE	(1L << PTE_PAGE_SHIFT)
to
#define PTE_PAGE_SIZE	(1 << PTE_PAGE_SHIFT)
the compiling is o.k.

Is that a compiler problem or an programming error ?

  Ralf



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Ralf Roesch.vcf --]
[-- Type: text/x-vcard; name="Ralf Roesch.vcf", Size: 460 bytes --]

BEGIN:VCARD
VERSION:2.1
N:Roesch;Ralf
FN:Ralf Roesch
ORG:Roesch & Walter Industrie-Elektronik GmbH
TITLE:Managing Director
TEL;WORK;VOICE:+49 (7824) 6628-0
TEL;WORK;FAX:+49 (+49) 7824 6628-29
ADR;WORK:;;Im Heidenwinkel 5;Schwanau;;77963;Deutschland
LABEL;WORK;ENCODING=QUOTED-PRINTABLE:Im Heidenwinkel 5=0D=0ASchwanau 77963=0D=0ADeutschland
URL;WORK:http://www.rw-gmbh.de
EMAIL;PREF;INTERNET:ralf.roesch@rw-gmbh.de
REV:20010405T072400Z
END:VCARD

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Compiler Problems in tlbex-r4k.S
@ 2003-10-23  9:33 ` Ralf Rösch
  0 siblings, 0 replies; 5+ messages in thread
From: Ralf Rösch @ 2003-10-23  9:33 UTC (permalink / raw)
  To: linux-mips

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

The latest update in tlbex-r4k.S (tag 2_4) produces
following compiler errors on my machine:

mipsel-linux-gcc -D__ASSEMBLY__ -D__KERNEL__ -I/build/linux-2.4.22-rthal5g-s
trom
boli/include -I /build/linux-2.4.22-rthal5g-stromboli/include/asm/gcc -G
0 -mno-
abicalls -fno-pic -pipe   -mcpu=r4600 -mips2 -Wa,--trap   -c -o tlbex-r4k.o
tlbe
x-r4k.S
tlbex-r4k.S: Assembler messages:
tlbex-r4k.S:179: Error: missing ')'
tlbex-r4k.S:179: Error: missing ')'
tlbex-r4k.S:179: Error: missing ')'
tlbex-r4k.S:179: Error: illegal operands `and'
tlbex-r4k.S:207: Error: missing ')'
tlbex-r4k.S:207: Error: missing ')'
tlbex-r4k.S:207: Error: missing ')'
tlbex-r4k.S:207: Error: illegal operands `and'
tlbex-r4k.S:243: Error: missing ')'
tlbex-r4k.S:243: Error: missing ')'
tlbex-r4k.S:243: Error: missing ')'
...

If I change the line 43 from:
#define PTE_PAGE_SIZE	(1L << PTE_PAGE_SHIFT)
to
#define PTE_PAGE_SIZE	(1 << PTE_PAGE_SHIFT)
the compiling is o.k.

Is that a compiler problem or an programming error ?

  Ralf



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Ralf Roesch.vcf --]
[-- Type: text/x-vcard; name="Ralf Roesch.vcf", Size: 460 bytes --]

BEGIN:VCARD
VERSION:2.1
N:Roesch;Ralf
FN:Ralf Roesch
ORG:Roesch & Walter Industrie-Elektronik GmbH
TITLE:Managing Director
TEL;WORK;VOICE:+49 (7824) 6628-0
TEL;WORK;FAX:+49 (+49) 7824 6628-29
ADR;WORK:;;Im Heidenwinkel 5;Schwanau;;77963;Deutschland
LABEL;WORK;ENCODING=QUOTED-PRINTABLE:Im Heidenwinkel 5=0D=0ASchwanau 77963=0D=0ADeutschland
URL;WORK:http://www.rw-gmbh.de
EMAIL;PREF;INTERNET:ralf.roesch@rw-gmbh.de
REV:20010405T072400Z
END:VCARD

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Compiler Problems in tlbex-r4k.S
  2003-10-23  9:33 ` Ralf Rösch
  (?)
@ 2003-10-23  9:43 ` Geert Uytterhoeven
  2003-10-23 16:33   ` Ralf Baechle
  -1 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2003-10-23  9:43 UTC (permalink / raw)
  To: Ralf Rösch; +Cc: Linux/MIPS Development

On Thu, 23 Oct 2003, [iso-8859-1] Ralf Rösch wrote:
> The latest update in tlbex-r4k.S (tag 2_4) produces
> following compiler errors on my machine:
> 
> mipsel-linux-gcc -D__ASSEMBLY__ -D__KERNEL__ -I/build/linux-2.4.22-rthal5g-s
> trom
> boli/include -I /build/linux-2.4.22-rthal5g-stromboli/include/asm/gcc -G
> 0 -mno-
> abicalls -fno-pic -pipe   -mcpu=r4600 -mips2 -Wa,--trap   -c -o tlbex-r4k.o
> tlbe
> x-r4k.S
> tlbex-r4k.S: Assembler messages:
> tlbex-r4k.S:179: Error: missing ')'
> tlbex-r4k.S:179: Error: missing ')'
> tlbex-r4k.S:179: Error: missing ')'
> tlbex-r4k.S:179: Error: illegal operands `and'
> tlbex-r4k.S:207: Error: missing ')'
> tlbex-r4k.S:207: Error: missing ')'
> tlbex-r4k.S:207: Error: missing ')'
> tlbex-r4k.S:207: Error: illegal operands `and'
> tlbex-r4k.S:243: Error: missing ')'
> tlbex-r4k.S:243: Error: missing ')'
> tlbex-r4k.S:243: Error: missing ')'
> ...
> 
> If I change the line 43 from:
> #define PTE_PAGE_SIZE	(1L << PTE_PAGE_SHIFT)
> to
> #define PTE_PAGE_SIZE	(1 << PTE_PAGE_SHIFT)
> the compiling is o.k.
> 
> Is that a compiler problem or an programming error ?

That's a programming error. The assembler doesn't know 1L, it needs plain 1.

Yes, it makes life hard, if you want to share your definitions between the
C compiler and the assembler.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Compiler Problems in tlbex-r4k.S
  2003-10-23  9:43 ` Geert Uytterhoeven
@ 2003-10-23 16:33   ` Ralf Baechle
  2003-10-23 18:41     ` Kip Walker
  0 siblings, 1 reply; 5+ messages in thread
From: Ralf Baechle @ 2003-10-23 16:33 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Ralf R?sch, Linux/MIPS Development

On Thu, Oct 23, 2003 at 11:43:27AM +0200, Geert Uytterhoeven wrote:

> > If I change the line 43 from:
> > #define PTE_PAGE_SIZE	(1L << PTE_PAGE_SHIFT)
> > to
> > #define PTE_PAGE_SIZE	(1 << PTE_PAGE_SHIFT)
> > the compiling is o.k.

The fix for this went into CVS yesterday.

> That's a programming error. The assembler doesn't know 1L, it needs plain 1.
> 
> Yes, it makes life hard, if you want to share your definitions between the
> C compiler and the assembler.

It's a PITA that gas doesn't accept constants in the same syntax as C
does.  It means we have to extract many constants into offset.h before
they can be used in assembler code.  One of the small things on my
wishlist for x-mas ;-)

  Ralf

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Compiler Problems in tlbex-r4k.S
  2003-10-23 16:33   ` Ralf Baechle
@ 2003-10-23 18:41     ` Kip Walker
  0 siblings, 0 replies; 5+ messages in thread
From: Kip Walker @ 2003-10-23 18:41 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: Geert Uytterhoeven, Ralf R?sch, Linux/MIPS Development

Ralf Baechle wrote:
> 
> On Thu, Oct 23, 2003 at 11:43:27AM +0200, Geert Uytterhoeven wrote:
> 
> > > If I change the line 43 from:
> > > #define PTE_PAGE_SIZE       (1L << PTE_PAGE_SHIFT)
> > > to
> > > #define PTE_PAGE_SIZE       (1 << PTE_PAGE_SHIFT)
> > > the compiling is o.k.
> 
> The fix for this went into CVS yesterday.

Actually, this is a new problem which was my fault.  I'm checking in the
fix.

Apologies!

Kip

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2003-10-23 18:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-23  9:33 Compiler Problems in tlbex-r4k.S Ralf Rösch
2003-10-23  9:33 ` Ralf Rösch
2003-10-23  9:43 ` Geert Uytterhoeven
2003-10-23 16:33   ` Ralf Baechle
2003-10-23 18:41     ` Kip Walker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.