libaal compile fails

libaal compile fails

[Sævaldur Gunnarsson]

[-- Attachment #1.1: Type: text/plain, Size: 1451 bytes --]

When I try building libaal it fails with the following error message:

make[2]: Entering directory
`/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13/src'
source='file.c' object='libaal_la-file.lo' libtool=yes \
depfile='.deps/libaal_la-file.Plo'
tmpdepfile='.deps/libaal_la-file.TPlo' \
depmode=gcc3 /bin/sh ../depcomp \
/bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I..
-I../include   -D_REENTRANT -D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall
-Wno-unused-parameter -Wredundant-decls -Werror -c -o libaal_la-file.lo
`test -f file.c || echo './'`file.c
rm -f .libs/libaal_la-file.lo
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -D_REENTRANT
-D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall -Wno-unused-parameter
-Wredundant-decls -Werror -c file.c -MT libaal_la-file.lo -MD -MP -MF
.deps/libaal_la-file.TPlo  -fPIC -DPIC -o .libs/libaal_la-file.lo
file.c: In function `file_len':
file.c:213: parse error before '[' token
cc1: warnings being treated as errors
file.c:213: warning: signed and unsigned type in conditional expression
make[2]: *** [libaal_la-file.lo] Error 1
make[2]: Leaving directory
`/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13'
make: *** [all] Error 2
titanium /usr/src/linux/libaal-0.4.13#



Sævaldur Gunnarsson: RHCE
Let justice be done; though the
world perish

[-- Attachment #1.2: Type: text/html, Size: 2152 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: libaal compile fails

[Yury Umanets]

 >>When I try building libaal it fails with the following error message:

 >>make[2]: Entering directory 
`/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13/src'
 >>source='file.c' object='libaal_la-file.lo' libtool=yes \
 >>depfile='.deps/libaal_la-file.Plo' 
tmpdepfile='.deps/libaal_la-file.TPlo' \
 >>depmode=gcc3 /bin/sh ../depcomp \
 >>/bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. 
-I../include   -D_REENTRANT -D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall 
 >>-Wno-unused-parameter -Wredundant-decls -Werror -c -o 
libaal_la-file.lo `test -f file.c || echo './'`file.c
 >>rm -f .libs/libaal_la-file.lo
 >>gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -D_REENTRANT 
-D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall -Wno-unused-parameter 
 >>-Wredundant-decls -Werror -c file.c -MT libaal_la-file.lo -MD -MP -MF 
.deps/libaal_la-file.TPlo  -fPIC -DPIC -o .libs/libaal_la-file.lo
 >>file.c: In function `file_len':
 >>file.c:213: parse error before '[' token
 >>cc1: warnings being treated as errors
 >>file.c:213: warning: signed and unsigned type in conditional expression
 >>make[2]: *** [libaal_la-file.lo] Error 1
 >>make[2]: Leaving directory 
`/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13/src'
 >>make[1]: *** [all-recursive] Error 1
 >>make[1]: Leaving directory 
`/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13'
 >>make: *** [all] Error 2
 >>titanium /usr/src/linux/libaal-0.4.13#

Hello,

This is pretty strange. Line 213 does not contain any "[" tokens and 
suspicious macros. Have you got correct sources? Can you send me line 
213 with context?

Also use please configure with option --disable-Werror specified.

-- 
umka

Re: libaal compile fails

[Yury Umanets]

Yury Umanets wrote:

> >>When I try building libaal it fails with the following error message:
>
> >>make[2]: Entering directory 
> `/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13/src'
> >>source='file.c' object='libaal_la-file.lo' libtool=yes \
> >>depfile='.deps/libaal_la-file.Plo' 
> tmpdepfile='.deps/libaal_la-file.TPlo' \
> >>depmode=gcc3 /bin/sh ../depcomp \
> >>/bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. 
> -I../include   -D_REENTRANT -D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall 
> >>-Wno-unused-parameter -Wredundant-decls -Werror -c -o 
> libaal_la-file.lo `test -f file.c || echo './'`file.c
> >>rm -f .libs/libaal_la-file.lo
> >>gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -D_REENTRANT 
> -D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall -Wno-unused-parameter 
> >>-Wredundant-decls -Werror -c file.c -MT libaal_la-file.lo -MD -MP 
> -MF .deps/libaal_la-file.TPlo  -fPIC -DPIC -o .libs/libaal_la-file.lo
> >>file.c: In function `file_len':
> >>file.c:213: parse error before '[' token
> >>cc1: warnings being treated as errors
> >>file.c:213: warning: signed and unsigned type in conditional expression
> >>make[2]: *** [libaal_la-file.lo] Error 1
> >>make[2]: Leaving directory 
> `/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13/src'
> >>make[1]: *** [all-recursive] Error 1
> >>make[1]: Leaving directory 
> `/raid/disc0/usr/src/linux-2.6.0-test9/libaal-0.4.13'
> >>make: *** [all] Error 2
> >>titanium /usr/src/linux/libaal-0.4.13#
>
> Hello,
>
> This is pretty strange. Line 213 does not contain any "[" tokens and 
> suspicious macros. Have you got correct sources? Can you send me line 
> 213 with context?
>
> Also use please configure with option --disable-Werror specified.
>
Forgot to ask. Do you use recent snapshot of libaal?

-- 
umka

Re: libaal compile fails

[Tupshin Harper]

Yury Umanets wrote:

> Yury Umanets wrote:
>
>> >>When I try building libaal it fails with the following error message:
>>
> Forgot to ask. Do you use recent snapshot of libaal?
>
FWIW, I get the exact same problem as Saevaldur. Using 
libaal-0.4.13.tar.gz, and attempting to compile on a Debian Sid x86 
machine. I can only imagine it's a gcc parsing bug (line 213 indeed does 
not have a square bracket). GCC is 3.3.2. Commenting out the check 
performed by that line results in a sucesful compilation.

-Tupshin

Re: libaal compile fails

[Tupshin Harper]

Tupshin Harper wrote:

> Yury Umanets wrote:
>
>> Yury Umanets wrote:
>>
>>> >>When I try building libaal it fails with the following error message:
>>>
>> Forgot to ask. Do you use recent snapshot of libaal?
>>
> FWIW, I get the exact same problem as Saevaldur. Using 
> libaal-0.4.13.tar.gz, and attempting to compile on a Debian Sid x86 
> machine. I can only imagine it's a gcc parsing bug (line 213 indeed 
> does not have a square bracket). GCC is 3.3.2. Commenting out the 
> check performed by that line results in a sucesful compilation.
>
> -Tupshin
>
A bit more info.

It is not a problem with the gcc version, as the same message comes from 
3.2 and 2.95.

I'm guessing that it emerges from macros expanded through multiple 
layers of expansion.
BLKGETSIZE64 expands to _
IOR(0x12, 114, sizeof(uint64_t))

_IOR expands to
_IOC(_IOC_READ,(type),(nr),(_IOC_TYPECHECK(size)))

and _IOC_TYPECHECK expands to
((sizeof(t) == sizeof(t[1]) && sizeof(t) < (1 << _IOC_SIZEBITS)) ? 
sizeof(t) : __invalid_size_argument_for_IOC)

which is the first hint of a bracket on that line. That's as far as I'm 
going ;-).

-Tupshin

Re: libaal compile fails

[Yury V. Umanets]

On Sun, 2003-11-09 at 12:46, Tupshin Harper wrote:
> Tupshin Harper wrote:
> 
> > Yury Umanets wrote:
> >
> >> Yury Umanets wrote:
> >>
> >>> >>When I try building libaal it fails with the following error message:
> >>>
> >> Forgot to ask. Do you use recent snapshot of libaal?
> >>
> > FWIW, I get the exact same problem as Saevaldur. Using 
> > libaal-0.4.13.tar.gz, and attempting to compile on a Debian Sid x86 
> > machine. I can only imagine it's a gcc parsing bug (line 213 indeed 
> > does not have a square bracket). GCC is 3.3.2. Commenting out the 
> > check performed by that line results in a sucesful compilation.
> >
> > -Tupshin
> >
> A bit more info.
> 
> It is not a problem with the gcc version, as the same message comes from 
> 3.2 and 2.95.
> 
> I'm guessing that it emerges from macros expanded through multiple 
> layers of expansion.
> BLKGETSIZE64 expands to _
> IOR(0x12, 114, sizeof(uint64_t))
> 
> _IOR expands to
> _IOC(_IOC_READ,(type),(nr),(_IOC_TYPECHECK(size)))
> 
> and _IOC_TYPECHECK expands to
> ((sizeof(t) == sizeof(t[1]) && sizeof(t) < (1 << _IOC_SIZEBITS)) ? 
> sizeof(t) : __invalid_size_argument_for_IOC)
> 
> which is the first hint of a bracket on that line. That's as far as I'm 
> going ;-).
> 
> -Tupshin
Hello,

First of all thanks for shutting a bug. There is really one error in the
macro you have pointed to. 

Old variant is:

#if defined(__linux__) && defined(_IOR) && !defined(BLKGETSIZE64)
#   define BLKGETSIZE64 _IOR(0x12, 114, sizeof(uint64_t))
#endif

New variant (right one) is:

#if defined(__linux__) && defined(_IOR) && !defined(BLKGETSIZE64)
#   define BLKGETSIZE64 _IOR(0x12, 114, uint64_t)
#endif

But I don't think, that problem is related to it. Also, we have not such
a error on gcc 3.3.1 and older. Can you try to build libaal with this
fix and see what happens?


Thanks.
-- 
umka

Re: libaal compile fails

[Eric Wong]

Hi, I'm still having problems with compiling libaal on Debian
sid/unstable after trying the proposed-fix here:

http://marc.theaimsgroup.com/?l=reiserfs&m=106841085428596&w=2

Here is the output I got after making the above changes to the BLKGETSIZE64
macro:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -D_REENTRANT
-D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall -Wno-unused -Wredundant-decls
-Werror -c file.c -Wp,-MD,.deps/libaal_la-file.TPlo  -fPIC -DPIC -o
.libs/libaal_la-file.lo
file.c: In function `file_len':
file.c:213: warning: signed and unsigned type in conditional expression
make[2]: *** [libaal_la-file.lo] Error 1

I'm using gcc 3.3.2 and the somewhat troublesome (yet standard fare in
Debian unstable nowadays) linux-kernel-headers package that provides
kernel headers for glibc.  I'm running 2.6.0-test9

This package compiles fine on my Debian stable/Woody system, however.

If you need any more info, let me know.  Thanks.

-- 
Eric Wong  (normalperson on OFTC and Freenode)

Re: libaal compile fails

[Yury V. Umanets]

On Wed, 2003-11-19 at 22:35, Eric Wong wrote:
> Hi, I'm still having problems with compiling libaal on Debian
> sid/unstable after trying the proposed-fix here:
> 
> http://marc.theaimsgroup.com/?l=reiserfs&m=106841085428596&w=2
> 
> Here is the output I got after making the above changes to the BLKGETSIZE64
> macro:
> 
> gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -D_REENTRANT
> -D_FILE_OFFSET_BITS=64 -O0 -g -W -Wall -Wno-unused -Wredundant-decls
> -Werror -c file.c -Wp,-MD,.deps/libaal_la-file.TPlo  -fPIC -DPIC -o
> .libs/libaal_la-file.lo
> file.c: In function `file_len':
> file.c:213: warning: signed and unsigned type in conditional expression
> make[2]: *** [libaal_la-file.lo] Error 1
> 
> I'm using gcc 3.3.2 and the somewhat troublesome (yet standard fare in
> Debian unstable nowadays) linux-kernel-headers package that provides
> kernel headers for glibc.  I'm running 2.6.0-test9
> 
> This package compiles fine on my Debian stable/Woody system, however.
> 
> If you need any more info, let me know.  Thanks.
Hello,

Thanks for shooting the bug, will be fixed.

Use --disable-Werror option in configure as temporal workaround. Next
snapshot has it turned on by default. 
-- 
umka