All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karim Yaghmour <karim@opersys.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: USB Audio problems
Date: Thu, 20 Nov 2003 15:28:25 -0500	[thread overview]
Message-ID: <3FBD23E9.1060609@opersys.com> (raw)
In-Reply-To: <s5hoev7ywfw.wl@alsa2.suse.de>


Takashi Iwai wrote:
> it'd be better to clean unlink_mask in the complete callback for the
> case you use async unlink mode (see below).
> and, the check of active_mask should be done in prepare callback, not
> in the trigger callback.  the trigger callback must be as short as
> possible.  we can put deactivate_urbs() in prepre callback so that the
> urbs become clean before starting streams.

Sounds right.

> (but still we have a problem of async unlink because prepare callback
>  is also in the spinlocked context.)

Would it be fair to say that this driver requires some major rework?

Karim
-- 
Author, Speaker, Developer, Consultant
Pushing Embedded and Real-Time Linux Systems Beyond the Limits
http://www.opersys.com || karim@opersys.com || 514-812-4145



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

  parent reply	other threads:[~2003-11-20 20:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-19 19:28 USB Audio problems Karim Yaghmour
2003-11-20  5:50 ` Karim Yaghmour
2003-11-20 10:04   ` Niklas Werner
2003-11-20 11:10     ` Takashi Iwai
2003-11-20 20:25     ` Karim Yaghmour
2003-11-20 13:57   ` Takashi Iwai
2003-11-20 14:33     ` Patrick Shirkey
2003-11-21 15:21       ` Takashi Iwai
2003-11-21 16:50         ` Patrick Shirkey
2003-11-20 20:28     ` Karim Yaghmour [this message]
2003-11-21 10:37       ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2003-11-21 11:31 Denis de Leeuw Duarte
2003-08-29 19:25 usb audio problems np

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FBD23E9.1060609@opersys.com \
    --to=karim@opersys.com \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.