Re: USB Audio problems

[Takashi Iwai <tiwai@suse.de>]

At Thu, 20 Nov 2003 15:28:25 -0500,
Karim Yaghmour wrote:
> 
> 
> Takashi Iwai wrote:
> > it'd be better to clean unlink_mask in the complete callback for the
> > case you use async unlink mode (see below).
> > and, the check of active_mask should be done in prepare callback, not
> > in the trigger callback.  the trigger callback must be as short as
> > possible.  we can put deactivate_urbs() in prepre callback so that the
> > urbs become clean before starting streams.
> 
> Sounds right.
 
already changed on cvs :)  will be reflected to 1.0.0-test2.

> > (but still we have a problem of async unlink because prepare callback
> >  is also in the spinlocked context.)
> 
> Would it be fair to say that this driver requires some major rework?

yes.  not much in usbaudio.c itself but in the core PCM part.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/