[patch] sis comparison / assignment operator fix

[patch] sis comparison / assignment operator fix

[Geoffrey Lee]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hi,


This fixes what seems to be an obvious = vs == bug in the init301.c
sis file.

It has 

if (temp = 0xffff) return;

which should always be true, so it always returns.

	- g.
-- 
geoff.

[-- Attachment #2: sis-init301.c.patch --]
[-- Type: text/plain, Size: 480 bytes --]

--- linux-2.6.0-test10/drivers/video/sis/init301.c.orig	2003-11-24 14:36:57.000000000 +0800
+++ linux-2.6.0-test10/drivers/video/sis/init301.c	2003-11-24 14:37:59.000000000 +0800
@@ -11712,7 +11712,7 @@ SetOEMLCDData(SiS_Private *SiS_Pr, PSIS_
   }
 
   temp = GetOEMLCDPtr(SiS_Pr,HwDeviceExtension, ROMAddr, 1);
-  if(temp = 0xFFFF) return;
+  if(temp == 0xFFFF) return;
 
   index = SiS_Pr->SiS_VBModeIDTable[ModeIdIndex]._VB_LCDHIndex;
   for(i=0x14, j=0; i<=0x17; i++, j++) {

Re: [patch] sis comparison / assignment operator fix

[Thomas Winischhofer]

Geoffrey Lee wrote:
  > This fixes what seems to be an obvious = vs == bug in the init301.c
  > sis file.
  >
  > It has
  >
  > if (temp = 0xffff) return;
  >
  > which should always be true, so it always returns.

You did notice the "#if 0" - "#endif" around that code, didn't you?

BTW: Patching a more than 10 months old version of that driver is
pointless anyway. The current fb-related development is exclusively done
in James Simmon's fbdev tree, and current versions of the sisfb driver
are obtainable at http://www.winischhofer.net/linuxsisvga.shtml

Thomas

-- 
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net          *** http://www.winischhofer.net/
twini AT xfree86 DOT org