* e100 in net-drivers-2.5-exp
@ 2003-12-16 18:43 Stephen Hemminger
2003-12-16 22:36 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2003-12-16 18:43 UTC (permalink / raw)
To: Feldman, Scott, Jeff Garzik; +Cc: netdev
e100 in net-drivers-2.5-exp won't compile as a module.
Don't think the new module_param() works the way it is being used
in the new e100 driver.
CC [M] drivers/net/e100.o
drivers/net/e100.c:170: error: parse error before "int"
drivers/net/e100.c:170: warning: type defaults to `int' in declaration of `module_param'
drivers/net/e100.c:170: warning: function declaration isn't a prototype
drivers/net/e100.c:170: warning: data definition has no type or storage class
--
Stephen Hemminger mailto:shemminger@osdl.org
Open Source Development Lab http://developer.osdl.org/shemminger
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: e100 in net-drivers-2.5-exp
2003-12-16 18:43 e100 in net-drivers-2.5-exp Stephen Hemminger
@ 2003-12-16 22:36 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2003-12-16 22:36 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Feldman, Scott, netdev
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
Stephen Hemminger wrote:
> e100 in net-drivers-2.5-exp won't compile as a module.
>
> Don't think the new module_param() works the way it is being used
> in the new e100 driver.
>
> CC [M] drivers/net/e100.o
> drivers/net/e100.c:170: error: parse error before "int"
> drivers/net/e100.c:170: warning: type defaults to `int' in declaration of `module_param'
> drivers/net/e100.c:170: warning: function declaration isn't a prototype
> drivers/net/e100.c:170: warning: data definition has no type or storage class
Thanks, just checked in the attached patch to fix this.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 338 bytes --]
===== drivers/net/e100.c 1.2 vs edited =====
--- 1.2/drivers/net/e100.c Tue Dec 9 15:38:42 2003
+++ edited/drivers/net/e100.c Tue Dec 16 17:35:12 2003
@@ -136,6 +136,7 @@
#include <linux/config.h>
#include <linux/module.h>
+#include <linux/moduleparam.h>
#include <linux/kernel.h>
#include <linux/types.h>
#include <linux/slab.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-12-16 22:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-12-16 18:43 e100 in net-drivers-2.5-exp Stephen Hemminger
2003-12-16 22:36 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.