Re: [PATCH v1 4/9] asm-generic: move Arm's static-memory.h to asm-generic

[Oleksii Kurochko <oleksii.kurochko@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]


On 1/27/25 12:19 PM, Jan Beulich wrote:
> On 08.01.2025 12:13, Oleksii Kurochko wrote:
>> Except moving Arm's static-memory.h to asm-generic #ifdef header guard
>> is updated: s/__ASM_STATIC_MEMORY_H_/__ASM_GENERIC_STATIC_MEMORY_H__.
>>
>> Update arm/include/asm/Makefile to use asm-generic version of
>> static-memory.h for Arm.
>>
>> Signed-off-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>
> Here as well as in patch 5 the "why" is again missing. Moving is fine, as
> long as it's clear that this will actually be used by another arch (e.g.
> RISC-V). Whether you have such (immediate or at least near term) plans is
> unclear though, as both features look like relatively advanced ones, and
> hence more basic functionality may want to appear first in RISC-V.

The reason is that suggested generic dom0less solution is using allocate_static_memory() and
assign_static_memory_11() so I decided that it would be better to have stubs for them in
asm-generic header that wrapping by the code by "#ifdef CONFIG_STATIC_MEMORY" the places where
it is used.
But considering the status of RISC-V's Xen downstream and I still don't have cases where CONFIG_STATIC_MEMORY
is used for RISC-V, probably, it would be better just to use wrapping in generic code instead of
stubs.

~ Oleksii

[-- Attachment #2: Type: text/html, Size: 1885 bytes --]