5.10-rc0: build error in ipi.c

5.10-rc0: build error in ipi.c

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Hi!

I'm getting build problems in 5.10-rc0 in config for n900. ARM board.

CONFIG_SMP=y
CONFIG_SMP_ON_UP=y


  CC      net/devres.o
  kernel/irq/ipi.c: In function ‘irq_reserve_ipi’:
  kernel/irq/ipi.c:84:9: error: implicit declaration of function
  ‘__irq_domain_alloc_irqs’; did you mean ‘irq_domain_alloc_irqs’?
  [-Werror=implicit-function-declaration]
    virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs,
  NUMA_NO_NODE,
           ^~~~~~~~~~~~~~~~~~~~~~~
	            irq_domain_alloc_irqs
		    cc1: some warnings being treated as errors
		    make[2]: *** [scripts/Makefile.build:283:
  kernel/irq/ipi.o] Error 1
  make[1]: *** [scripts/Makefile.build:500: kernel/irq] Error 2
  make: *** [Makefile:1775: kernel] Error 2
  make: *** Waiting for unfinished jobs....
    CC      net/socket.o

Best regards,
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: 5.10-rc0: build error in ipi.c

[Thomas Gleixner]

On Thu, Oct 15 2020 at 12:12, Pavel Machek wrote:

Cc+ Marc

> I'm getting build problems in 5.10-rc0 in config for n900. ARM board.
>
> CONFIG_SMP=y
> CONFIG_SMP_ON_UP=y
>
>
>   CC      net/devres.o
>   kernel/irq/ipi.c: In function ‘irq_reserve_ipi’:
>   kernel/irq/ipi.c:84:9: error: implicit declaration of function
>   ‘__irq_domain_alloc_irqs’; did you mean ‘irq_domain_alloc_irqs’?
>   [-Werror=implicit-function-declaration]
>     virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs,
>   NUMA_NO_NODE,
>            ^~~~~~~~~~~~~~~~~~~~~~~
> 	            irq_domain_alloc_irqs
> 		    cc1: some warnings being treated as errors
> 		    make[2]: *** [scripts/Makefile.build:283:
>   kernel/irq/ipi.o] Error 1

That probably comes from the ipi as irq rework for arm/arm64.

Thanks,

        tglx

Re: 5.10-rc0: build error in ipi.c

[Marc Zyngier]

On 2020-10-15 15:23, Thomas Gleixner wrote:
> On Thu, Oct 15 2020 at 12:12, Pavel Machek wrote:
> 
> Cc+ Marc

Thanks Thomas.

> 
>> I'm getting build problems in 5.10-rc0 in config for n900. ARM board.
>> 
>> CONFIG_SMP=y
>> CONFIG_SMP_ON_UP=y

On its own, this doesn't break anything with multi_v7_defconfig.

>> 
>> 
>>   CC      net/devres.o
>>   kernel/irq/ipi.c: In function ‘irq_reserve_ipi’:
>>   kernel/irq/ipi.c:84:9: error: implicit declaration of function
>>   ‘__irq_domain_alloc_irqs’; did you mean ‘irq_domain_alloc_irqs’?
>>   [-Werror=implicit-function-declaration]
>>     virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs,
>>   NUMA_NO_NODE,
>>            ^~~~~~~~~~~~~~~~~~~~~~~
>> 	            irq_domain_alloc_irqs
>> 		    cc1: some warnings being treated as errors
>> 		    make[2]: *** [scripts/Makefile.build:283:
>>   kernel/irq/ipi.o] Error 1
> 
> That probably comes from the ipi as irq rework for arm/arm64.

Most probably.

Pawel, can you please stash your config somewhere where I can get it?

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

Re: 5.10-rc0: build error in ipi.c

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi!

> > > I'm getting build problems in 5.10-rc0 in config for n900. ARM board.
> > > 
> > > CONFIG_SMP=y
> > > CONFIG_SMP_ON_UP=y
> 
> On its own, this doesn't break anything with multi_v7_defconfig.

I sent config off-list. Let me know if it does not arrive or if you
need more info.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: 5.10-rc0: build error in ipi.c

[Marc Zyngier]

On 2020-10-15 18:18, Pavel Machek wrote:
> Hi!
> 
>> > > I'm getting build problems in 5.10-rc0 in config for n900. ARM board.
>> > >
>> > > CONFIG_SMP=y
>> > > CONFIG_SMP_ON_UP=y
>> 
>> On its own, this doesn't break anything with multi_v7_defconfig.
> 
> I sent config off-list. Let me know if it does not arrive or if you
> need more info.

Try this for size:

diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
index 10a5aff4eecc..db923e0da162 100644
--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS

  # Generic IRQ IPI support
  config GENERIC_IRQ_IPI
+	select IRQ_DOMAIN_HIERARCHY
  	bool

  # Generic MSI interrupt support


         N,
-- 
Jazz is not dead. It just smells funny...

Re: 5.10-rc0: build error in ipi.c

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Thu 2020-10-15 20:41:32, Marc Zyngier wrote:
> On 2020-10-15 18:18, Pavel Machek wrote:
> > Hi!
> > 
> > > > > I'm getting build problems in 5.10-rc0 in config for n900. ARM board.
> > > > >
> > > > > CONFIG_SMP=y
> > > > > CONFIG_SMP_ON_UP=y
> > > 
> > > On its own, this doesn't break anything with multi_v7_defconfig.
> > 
> > I sent config off-list. Let me know if it does not arrive or if you
> > need more info.
> 
> Try this for size:
> 
> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
> index 10a5aff4eecc..db923e0da162 100644
> --- a/kernel/irq/Kconfig
> +++ b/kernel/irq/Kconfig
> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
> 
>  # Generic IRQ IPI support
>  config GENERIC_IRQ_IPI
> +	select IRQ_DOMAIN_HIERARCHY
>  	bool
> 
>  # Generic MSI interrupt support
> 

My OCD prevents me from doing that! :-)...

select needs to be moved line below, for consistency. And yes, this
fixes it for me.

Tested-by: Pavel Machek <pavel@ucw.cz>
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: 5.10-rc0: build error in ipi.c

[Thomas Gleixner]

On Thu, Oct 15 2020 at 20:41, Marc Zyngier wrote:
> On 2020-10-15 18:18, Pavel Machek wrote:
> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
> index 10a5aff4eecc..db923e0da162 100644
> --- a/kernel/irq/Kconfig
> +++ b/kernel/irq/Kconfig
> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
>
>   # Generic IRQ IPI support
>   config GENERIC_IRQ_IPI
> +	select IRQ_DOMAIN_HIERARCHY
>   	bool

which makes some of the MIPS GENERIC_IRQ_IPI/IRQ_DOMAIN_HIERARCHY
Kconfig magic in drivers/irqchip/Kconfig obsolete.

Thanks,

        tglx

Re: 5.10-rc0: build error in ipi.c

[Marc Zyngier]

On 2020-10-16 00:24, Thomas Gleixner wrote:
> On Thu, Oct 15 2020 at 20:41, Marc Zyngier wrote:
>> On 2020-10-15 18:18, Pavel Machek wrote:
>> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
>> index 10a5aff4eecc..db923e0da162 100644
>> --- a/kernel/irq/Kconfig
>> +++ b/kernel/irq/Kconfig
>> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
>> 
>>   # Generic IRQ IPI support
>>   config GENERIC_IRQ_IPI
>> +	select IRQ_DOMAIN_HIERARCHY
>>   	bool
> 
> which makes some of the MIPS GENERIC_IRQ_IPI/IRQ_DOMAIN_HIERARCHY
> Kconfig magic in drivers/irqchip/Kconfig obsolete.

Good point. I'll queue this on top:

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index cd734df57c42..d2a651372e15 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -180,7 +180,6 @@ config IRQ_MIPS_CPU
  	select GENERIC_IRQ_CHIP
  	select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING
  	select IRQ_DOMAIN
-	select IRQ_DOMAIN_HIERARCHY if GENERIC_IRQ_IPI
  	select GENERIC_IRQ_EFFECTIVE_AFF_MASK

  config CLPS711X_IRQCHIP

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

Re: 5.10-rc0: build error in ipi.c

[Thomas Gleixner]

On Fri, Oct 16 2020 at 09:28, Marc Zyngier wrote:

> On 2020-10-16 00:24, Thomas Gleixner wrote:
>> On Thu, Oct 15 2020 at 20:41, Marc Zyngier wrote:
>>> On 2020-10-15 18:18, Pavel Machek wrote:
>>> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
>>> index 10a5aff4eecc..db923e0da162 100644
>>> --- a/kernel/irq/Kconfig
>>> +++ b/kernel/irq/Kconfig
>>> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
>>> 
>>>   # Generic IRQ IPI support
>>>   config GENERIC_IRQ_IPI
>>> +	select IRQ_DOMAIN_HIERARCHY
>>>   	bool
>> 
>> which makes some of the MIPS GENERIC_IRQ_IPI/IRQ_DOMAIN_HIERARCHY
>> Kconfig magic in drivers/irqchip/Kconfig obsolete.
>
> Good point. I'll queue this on top:
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index cd734df57c42..d2a651372e15 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -180,7 +180,6 @@ config IRQ_MIPS_CPU
>   	select GENERIC_IRQ_CHIP
>   	select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING
>   	select IRQ_DOMAIN
> -	select IRQ_DOMAIN_HIERARCHY if GENERIC_IRQ_IPI
>   	select GENERIC_IRQ_EFFECTIVE_AFF_MASK
>
>   config CLPS711X_IRQCHIP

There's another one for MIPS_GIC :)

[tip: irq/urgent] genirq: Let GENERIC_IRQ_IPI select IRQ_DOMAIN_HIERARCHY

[tip-bot2 for Marc Zyngier]

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     151a535171be6ff824a0a3875553ea38570f4c05
Gitweb:        https://git.kernel.org/tip/151a535171be6ff824a0a3875553ea38570f4c05
Author:        Marc Zyngier <maz@kernel.org>
AuthorDate:    Thu, 15 Oct 2020 21:41:44 +01:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Thu, 15 Oct 2020 21:41:44 +01:00

genirq: Let GENERIC_IRQ_IPI select IRQ_DOMAIN_HIERARCHY

kernel/irq/ipi.c otherwise fails to compile if nothing else
selects it.

Fixes: 379b656446a3 ("genirq: Add GENERIC_IRQ_IPI Kconfig symbol")
Reported-by: Pavel Machek <pavel@ucw.cz>
Tested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20201015101222.GA32747@amd
---
 kernel/irq/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
index 10a5aff..164a031 100644
--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -82,6 +82,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
 # Generic IRQ IPI support
 config GENERIC_IRQ_IPI
 	bool
+	select IRQ_DOMAIN_HIERARCHY
 
 # Generic MSI interrupt support
 config GENERIC_MSI_IRQ