All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: "Dylan.Wu" <fredwudi0305@gmail.com>
Cc: palmer@dabbelt.com, pjw@kernel.org, aou@eecs.berkeley.edu,
	 anup@brainfault.org, alex@ghiti.fr, atish.patra@linux.dev,
	 zhouquan@iscas.ac.cn, linux-riscv@lists.infradead.org,
	kvm@vger.kernel.org,  kvm-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] riscv: ptdump: Move pagetable definitions to common header
Date: Mon, 20 Jul 2026 20:58:23 -0600 (MDT)	[thread overview]
Message-ID: <3bb2f519-c70b-6c35-c404-6fbfe8adbeb1@kernel.org> (raw)
In-Reply-To: <20260701085030.124579-2-fredwudi0305@gmail.com>

Hi Dylan,

On Wed, 1 Jul 2026, Dylan.Wu wrote:

> Move the pagetable walking state and level definitions to a new
> arch/riscv/include/asm/ptdump.h header. This allows other parts
> of the kernel (like KVM) to reuse the ptdump attribute parsing
> logic.
> 
> To support different pagetable types (like G-stage), the attribute
> parsing logic in dump_prot() is updated to use attribute bits
> defined within the pg_level structure rather than a global array.

Could you please split this into two patches: the first, to create 
ptdump.h and move the declarations there and export note_page(); and the 
second, to make the attribute parsing and structure changes?  That will 
make the changes easier to review.  


thanks 

- Paul

WARNING: multiple messages have this Message-ID (diff)
From: Paul Walmsley <pjw@kernel.org>
To: "Dylan.Wu" <fredwudi0305@gmail.com>
Cc: palmer@dabbelt.com, pjw@kernel.org, aou@eecs.berkeley.edu,
	 anup@brainfault.org, alex@ghiti.fr, atish.patra@linux.dev,
	 zhouquan@iscas.ac.cn, linux-riscv@lists.infradead.org,
	kvm@vger.kernel.org,  kvm-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] riscv: ptdump: Move pagetable definitions to common header
Date: Mon, 20 Jul 2026 20:58:23 -0600 (MDT)	[thread overview]
Message-ID: <3bb2f519-c70b-6c35-c404-6fbfe8adbeb1@kernel.org> (raw)
In-Reply-To: <20260701085030.124579-2-fredwudi0305@gmail.com>

Hi Dylan,

On Wed, 1 Jul 2026, Dylan.Wu wrote:

> Move the pagetable walking state and level definitions to a new
> arch/riscv/include/asm/ptdump.h header. This allows other parts
> of the kernel (like KVM) to reuse the ptdump attribute parsing
> logic.
> 
> To support different pagetable types (like G-stage), the attribute
> parsing logic in dump_prot() is updated to use attribute bits
> defined within the pg_level structure rather than a global array.

Could you please split this into two patches: the first, to create 
ptdump.h and move the declarations there and export note_page(); and the 
second, to make the attribute parsing and structure changes?  That will 
make the changes easier to review.  


thanks 

- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Paul Walmsley <pjw@kernel.org>
To: "Dylan.Wu" <fredwudi0305@gmail.com>
Cc: palmer@dabbelt.com, pjw@kernel.org, aou@eecs.berkeley.edu,
	 anup@brainfault.org, alex@ghiti.fr, atish.patra@linux.dev,
	 zhouquan@iscas.ac.cn, linux-riscv@lists.infradead.org,
	kvm@vger.kernel.org,  kvm-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] riscv: ptdump: Move pagetable definitions to common header
Date: Mon, 20 Jul 2026 20:58:23 -0600 (MDT)	[thread overview]
Message-ID: <3bb2f519-c70b-6c35-c404-6fbfe8adbeb1@kernel.org> (raw)
In-Reply-To: <20260701085030.124579-2-fredwudi0305@gmail.com>

Hi Dylan,

On Wed, 1 Jul 2026, Dylan.Wu wrote:

> Move the pagetable walking state and level definitions to a new
> arch/riscv/include/asm/ptdump.h header. This allows other parts
> of the kernel (like KVM) to reuse the ptdump attribute parsing
> logic.
> 
> To support different pagetable types (like G-stage), the attribute
> parsing logic in dump_prot() is updated to use attribute bits
> defined within the pg_level structure rather than a global array.

Could you please split this into two patches: the first, to create 
ptdump.h and move the declarations there and export note_page(); and the 
second, to make the attribute parsing and structure changes?  That will 
make the changes easier to review.  


thanks 

- Paul

-- 
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv

  parent reply	other threads:[~2026-07-21  2:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01  8:50 [PATCH 0/2] riscv: ptdump: Refactor for KVM gstage ptdump support Dylan.Wu
2026-07-01  8:50 ` Dylan.Wu
2026-07-01  8:50 ` Dylan.Wu
2026-07-01  8:50 ` [PATCH 1/2] riscv: ptdump: Move pagetable definitions to common header Dylan.Wu
2026-07-01  8:50   ` Dylan.Wu
2026-07-01  8:50   ` Dylan.Wu
2026-07-01  9:01   ` sashiko-bot
2026-07-21  2:58   ` Paul Walmsley [this message]
2026-07-21  2:58     ` Paul Walmsley
2026-07-21  2:58     ` Paul Walmsley
2026-07-27 12:39     ` Dylan.Wu
2026-07-27 12:39       ` Dylan.Wu
2026-07-27 12:39       ` Dylan.Wu
2026-07-28 16:14     ` [PATCH v3 0/3] RISC-V KVM gstage page table dumper Dylan.Wu
2026-07-28 16:14       ` Dylan.Wu
2026-07-28 16:14       ` Dylan.Wu
2026-07-28 16:14       ` [PATCH v3 1/3] riscv: ptdump: Create ptdump.h and move declarations Dylan.Wu
2026-07-28 16:14         ` Dylan.Wu
2026-07-28 16:14         ` Dylan.Wu
2026-07-28 16:26         ` sashiko-bot
2026-07-28 16:14       ` [PATCH v3 2/3] riscv: ptdump: Use per-level attribute bits for parsing Dylan.Wu
2026-07-28 16:14         ` Dylan.Wu
2026-07-28 16:14         ` Dylan.Wu
2026-07-28 16:31         ` sashiko-bot
2026-07-28 16:14       ` [PATCH v3 3/3] KVM: riscv: Register ptdump with debugfs on guest creation Dylan.Wu
2026-07-28 16:14         ` Dylan.Wu
2026-07-28 16:14         ` Dylan.Wu
2026-07-28 16:50         ` sashiko-bot
2026-07-01  8:50 ` [PATCH 2/2] " Dylan.Wu
2026-07-01  8:50   ` Dylan.Wu
2026-07-01  8:50   ` Dylan.Wu
2026-07-01  9:06   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bb2f519-c70b-6c35-c404-6fbfe8adbeb1@kernel.org \
    --to=pjw@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@linux.dev \
    --cc=fredwudi0305@gmail.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=zhouquan@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.