From: James Smart <james.smart@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
Date: Thu, 09 Jul 2020 14:43:17 +0000 [thread overview]
Message-ID: <3c46ca75-54d7-7f75-edfb-514b34b003dc@broadcom.com> (raw)
In-Reply-To: <20200709105826.GH2571@kadam>
On 7/9/2020 3:58 AM, Dan Carpenter wrote:
> These variables are unsigned so the result of the subtraction is also
> unsigned and thus can't be negative. Change it to a comparison and
> remove the subtraction.
>
> Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: I reverse the if statement in v1
>
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 7285b0114837..2bb2c96e7784 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
> if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
> temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
> } else {
> - if ((start_idx - dbg_cnt) < 0) {
> + if (start_idx < dbg_cnt) {
> start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx);
> temp_idx = 0;
> } else {
Already resolved/accepted.
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?idwdd7d7b3442
Thank you though.
-- james
WARNING: multiple messages have this Message-ID (diff)
From: James Smart <james.smart@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
Date: Thu, 9 Jul 2020 07:43:17 -0700 [thread overview]
Message-ID: <3c46ca75-54d7-7f75-edfb-514b34b003dc@broadcom.com> (raw)
In-Reply-To: <20200709105826.GH2571@kadam>
On 7/9/2020 3:58 AM, Dan Carpenter wrote:
> These variables are unsigned so the result of the subtraction is also
> unsigned and thus can't be negative. Change it to a comparison and
> remove the subtraction.
>
> Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: I reverse the if statement in v1
>
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 7285b0114837..2bb2c96e7784 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
> if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
> temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
> } else {
> - if ((start_idx - dbg_cnt) < 0) {
> + if (start_idx < dbg_cnt) {
> start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx);
> temp_idx = 0;
> } else {
Already resolved/accepted.
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=77dd7d7b3442
Thank you though.
-- james
next prev parent reply other threads:[~2020-07-09 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 10:49 [PATCH] scsi: lpfc: Fix a condition in lpfc_dmp_dbg() Dan Carpenter
2020-07-09 10:49 ` Dan Carpenter
2020-07-09 10:56 ` Dan Carpenter
2020-07-09 10:56 ` Dan Carpenter
2020-07-09 10:58 ` [PATCH v2] " Dan Carpenter
2020-07-09 10:58 ` Dan Carpenter
2020-07-09 14:43 ` James Smart [this message]
2020-07-09 14:43 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c46ca75-54d7-7f75-edfb-514b34b003dc@broadcom.com \
--to=james.smart@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=dick.kennedy@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.