All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "David Virag" <virag.david003@gmail.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Sam Protsenko" <semen.protsenko@linaro.org>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 05/13] dt-bindings: usb: samsung,exynos-dwc3: Add Exynos7885 support
Date: Mon, 5 Aug 2024 07:47:12 +0200	[thread overview]
Message-ID: <3cbd3c49-e164-4bab-9a05-fdcbc01ee08b@kernel.org> (raw)
In-Reply-To: <20240804215458.404085-6-virag.david003@gmail.com>

On 04/08/2024 23:53, David Virag wrote:
> Exynos7885 SoC has a DWC3 compatible USB controller, so it can reuse the
> existing Exynos glue layer. Clocks are the same as on Exynos850.
> Document Exynos7885 compatible.
> 
> Signed-off-by: David Virag <virag.david003@gmail.com>
> ---
>  .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml         | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> index 2b3430cebe99..3ec849ef4bdb 100644
> --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> @@ -16,6 +16,7 @@ properties:
>        - samsung,exynos5250-dwusb3
>        - samsung,exynos5433-dwusb3
>        - samsung,exynos7-dwusb3
> +      - samsung,exynos7885-dwusb3
>        - samsung,exynos850-dwusb3

This should be compatible with exynos850, so you need oneOf: adding
items with two compatibles.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "David Virag" <virag.david003@gmail.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Sam Protsenko" <semen.protsenko@linaro.org>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 05/13] dt-bindings: usb: samsung,exynos-dwc3: Add Exynos7885 support
Date: Mon, 5 Aug 2024 07:47:12 +0200	[thread overview]
Message-ID: <3cbd3c49-e164-4bab-9a05-fdcbc01ee08b@kernel.org> (raw)
In-Reply-To: <20240804215458.404085-6-virag.david003@gmail.com>

On 04/08/2024 23:53, David Virag wrote:
> Exynos7885 SoC has a DWC3 compatible USB controller, so it can reuse the
> existing Exynos glue layer. Clocks are the same as on Exynos850.
> Document Exynos7885 compatible.
> 
> Signed-off-by: David Virag <virag.david003@gmail.com>
> ---
>  .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml         | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> index 2b3430cebe99..3ec849ef4bdb 100644
> --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> @@ -16,6 +16,7 @@ properties:
>        - samsung,exynos5250-dwusb3
>        - samsung,exynos5433-dwusb3
>        - samsung,exynos7-dwusb3
> +      - samsung,exynos7885-dwusb3
>        - samsung,exynos850-dwusb3

This should be compatible with exynos850, so you need oneOf: adding
items with two compatibles.

Best regards,
Krzysztof


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2024-08-05  5:47 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04 21:53 [PATCH 00/13] Add USB support to Exynos7885 David Virag
2024-08-04 21:53 ` David Virag
2024-08-04 21:53 ` [PATCH 01/13] dt-bindings: clock: exynos7885: Fix duplicated binding David Virag
2024-08-04 21:53   ` David Virag
2024-08-04 21:53 ` [PATCH 02/13] dt-bindings: clock: exynos7885: Add CMU_TOP PLL MUX indices David Virag
2024-08-04 21:53   ` David Virag
2024-08-04 21:53 ` [PATCH 03/13] dt-bindings: clock: exynos7885: Add indices for USB clocks David Virag
2024-08-04 21:53   ` David Virag
2024-08-04 21:53 ` [PATCH 04/13] dt-bindings: phy: samsung,usb3-drd-phy: Add Exynos7885 support David Virag
2024-08-04 21:53   ` David Virag
2024-08-05  5:46   ` Krzysztof Kozlowski
2024-08-05  5:46     ` Krzysztof Kozlowski
2024-08-04 21:53 ` [PATCH 05/13] dt-bindings: usb: samsung,exynos-dwc3: " David Virag
2024-08-04 21:53   ` David Virag
2024-08-05  5:47   ` Krzysztof Kozlowski [this message]
2024-08-05  5:47     ` Krzysztof Kozlowski
2024-08-04 21:53 ` [PATCH 06/13] clk: samsung: exynos7885: Update CLKS_NR_FSYS after bindings fix David Virag
2024-08-04 21:53   ` David Virag
2024-08-05  5:49   ` Krzysztof Kozlowski
2024-08-05  5:49     ` Krzysztof Kozlowski
2024-08-05 12:44     ` David Virag
2024-08-05 12:44       ` David Virag
2024-08-05 13:38       ` Krzysztof Kozlowski
2024-08-05 13:38         ` Krzysztof Kozlowski
2024-08-04 21:53 ` [PATCH 07/13] clk: samsung: exynos7885: Add missing MUX clocks from PLLs in CMU_TOP David Virag
2024-08-04 21:53   ` David Virag
2024-08-04 21:53 ` [PATCH 08/13] clk: samsung: clk-pll: Add support for pll_1418x David Virag
2024-08-04 21:53   ` David Virag
2024-08-04 21:53 ` [PATCH 09/13] clk: samsung: exynos7885: Add USB related clocks to CMU_FSYS David Virag
2024-08-04 21:53   ` David Virag
2024-08-05  5:50   ` Krzysztof Kozlowski
2024-08-05  5:50     ` Krzysztof Kozlowski
2024-08-04 21:53 ` [PATCH 10/13] usb: dwc3: exynos: Add support for Exynos7885 David Virag
2024-08-04 21:53   ` David Virag
2024-08-04 21:53 ` [PATCH 11/13] phy: exynos5-usbdrd: support Exynos7885 USB PHY David Virag
2024-08-04 21:53   ` David Virag
2024-08-05  5:52   ` Krzysztof Kozlowski
2024-08-05  5:52     ` Krzysztof Kozlowski
2024-08-04 21:53 ` [PATCH 12/13] arm64: dts: exynos: Enable USB in Exynos7885 David Virag
2024-08-04 21:53   ` David Virag
2024-08-05  5:52   ` Krzysztof Kozlowski
2024-08-05  5:52     ` Krzysztof Kozlowski
2024-08-04 21:53 ` [PATCH 13/13] arm64: dts: exynos: exynos7885-jackpotlte: Enable USB support David Virag
2024-08-04 21:53   ` David Virag
2024-08-05  5:45 ` [PATCH 00/13] Add USB support to Exynos7885 Krzysztof Kozlowski
2024-08-05  5:45   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cbd3c49-e164-4bab-9a05-fdcbc01ee08b@kernel.org \
    --to=krzk@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=virag.david003@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.