All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tester: Fix test timeout data
@ 2021-04-10  3:26 Inga Stotland
  2021-04-12 15:27 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Inga Stotland @ 2021-04-10  3:26 UTC (permalink / raw)
  To: ell

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

When advancing to a next test case, create test timeout with the tester
instance as user data.

Also, remove stray debug printfs.
---
 ell/tester.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/ell/tester.c b/ell/tester.c
index eedd66b..54fbb4b 100644
--- a/ell/tester.c
+++ b/ell/tester.c
@@ -131,18 +131,11 @@ static void teardown_callback(void *user_data)
 	struct l_tester *tester = user_data;
 	struct test_case *test;
 
-	printf("teardown %p\n", tester->test_entry);
-
 	test = tester->test_entry->data;
-	printf("teardown data %p\n", tester->test_entry->data);
 	test->stage = L_TESTER_STAGE_TEARDOWN;
 	test->teardown = false;
 
-	printf("Test name %p\n", test->name);
-	printf("Test name %s\n", test->name);
 	print_progress(test->name, COLOR_MAGENTA, "teardown");
-	printf("teardown\n");
-
 
 	if (test->teardown_func)
 		test->teardown_func(test->test_data);
@@ -189,7 +182,7 @@ static void next_test_case(struct l_tester *tester)
 
 	if (test->timeout > 0)
 		test->run_timer = l_timeout_create(test->timeout, test_timeout,
-								test, NULL);
+								tester, NULL);
 
 	test->stage = L_TESTER_STAGE_PRE_SETUP;
 
-- 
2.26.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tester: Fix test timeout data
  2021-04-10  3:26 [PATCH] tester: Fix test timeout data Inga Stotland
@ 2021-04-12 15:27 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2021-04-12 15:27 UTC (permalink / raw)
  To: ell

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Hi Inga,

On 4/9/21 10:26 PM, Inga Stotland wrote:
> When advancing to a next test case, create test timeout with the tester
> instance as user data.
> 
> Also, remove stray debug printfs.
> ---
>   ell/tester.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
> 

Applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-12 15:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-10  3:26 [PATCH] tester: Fix test timeout data Inga Stotland
2021-04-12 15:27 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.