From: James Bottomley <jejb@linux.ibm.com>
To: docfate111 <tdwilliamsiv@gmail.com>, linux-scsi@vger.kernel.org
Subject:
Date: Mon, 11 Oct 2021 21:23:41 -0400 [thread overview]
Message-ID: <3d3ea15a938acca44e1e522ff06129dbcedfc30b.camel@linux.ibm.com> (raw)
In-Reply-To: <20211011231530.GA22856@t>
On Mon, 2021-10-11 at 19:15 -0400, docfate111 wrote:
> linux-scsi@vger.kernel.org,
> linux-kernel@vger.kernel.org,
> martin.petersen@oracle.com
> Bcc:
> Subject: [PATCH] scsi_lib fix the NULL pointer dereference
> Reply-To:
>
> scsi_setup_scsi_cmnd should check for the pointer before
> scsi_command_size dereferences it.
Have you seen this? As in do you have a trace? This should be an
impossible condition, so we need to see where it came from. The patch
as proposed is not right, because if something is setting cmd_len
without setting the cmnd pointer we need the cause fixed rather than
applying a band aid in scsi_setup_scsi_cmnd().
James
next parent reply other threads:[~2021-10-12 1:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211011231530.GA22856@t>
2021-10-12 1:23 ` James Bottomley [this message]
2021-10-12 2:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d3ea15a938acca44e1e522ff06129dbcedfc30b.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tdwilliamsiv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.