* (no subject) [not found] <20211011231530.GA22856@t> @ 2021-10-12 1:23 ` James Bottomley 2021-10-12 2:30 ` Bart Van Assche 0 siblings, 1 reply; 2+ messages in thread From: James Bottomley @ 2021-10-12 1:23 UTC (permalink / raw) To: docfate111, linux-scsi On Mon, 2021-10-11 at 19:15 -0400, docfate111 wrote: > linux-scsi@vger.kernel.org, > linux-kernel@vger.kernel.org, > martin.petersen@oracle.com > Bcc: > Subject: [PATCH] scsi_lib fix the NULL pointer dereference > Reply-To: > > scsi_setup_scsi_cmnd should check for the pointer before > scsi_command_size dereferences it. Have you seen this? As in do you have a trace? This should be an impossible condition, so we need to see where it came from. The patch as proposed is not right, because if something is setting cmd_len without setting the cmnd pointer we need the cause fixed rather than applying a band aid in scsi_setup_scsi_cmnd(). James ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2021-10-12 1:23 ` James Bottomley @ 2021-10-12 2:30 ` Bart Van Assche 0 siblings, 0 replies; 2+ messages in thread From: Bart Van Assche @ 2021-10-12 2:30 UTC (permalink / raw) To: jejb, docfate111, linux-scsi On 10/11/21 18:23, James Bottomley wrote: > On Mon, 2021-10-11 at 19:15 -0400, docfate111 wrote: >> linux-scsi@vger.kernel.org, >> linux-kernel@vger.kernel.org, >> martin.petersen@oracle.com >> Bcc: >> Subject: [PATCH] scsi_lib fix the NULL pointer dereference >> Reply-To: >> >> scsi_setup_scsi_cmnd should check for the pointer before >> scsi_command_size dereferences it. > > Have you seen this? As in do you have a trace? This should be an > impossible condition, so we need to see where it came from. The patch > as proposed is not right, because if something is setting cmd_len > without setting the cmnd pointer we need the cause fixed rather than > applying a band aid in scsi_setup_scsi_cmnd(). Hi James and Thelford, This patch looks like a duplicate of a patch posted one month ago? I think Christoph agrees to remove the cmd_len == 0 check. See also https://lore.kernel.org/linux-scsi/20210904064534.1919476-1-qiulaibin@huawei.com/. Thanks, Bart. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-12 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211011231530.GA22856@t>
2021-10-12 1:23 ` James Bottomley
2021-10-12 2:30 ` Bart Van Assche
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.