From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Jürgen Groß" <jgross@suse.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v2] docs: submitting-patches: Clarify half-baked review tags
Date: Thu, 5 Nov 2026 17:22:53 +0100 [thread overview]
Message-ID: <3d535c77-eca2-4774-a327-e301a4f6c34d@kernel.org> (raw)
In-Reply-To: <128f8491-d7d6-4b8d-85e5-20ce9ac506d6@suse.com>
On 05/11/2026 16:59, Jürgen Groß wrote:
> On 05.11.26 16:53, Krzysztof Kozlowski wrote:
>> Reviewing pieces of the patch while ignoring the main part of it, is
>> much closer to Acknowledgment, thus Ack, and "Reviewed-by" credit should
>> not be applicable.
>
> I disagree with:
>
> >> Reviewing pieces of the patch while ignoring the main part of it, is
> >> much closer to Acknowledgment, thus Ack, and "Reviewed-by" credit should
> >> not be applicable.
>
> And I agree with Andy's statement:
>
> >> TL;DR: As a reviewer for the piece in question I have done my part fully. It's
> >> not my issue that the piece is bundled into a single patch. We have options:
> >> 1) ask to split (and review as standalone piece);
> >> 2) add (partial) Rb with the pointers of what exactly has been reviewed;
> >> 3) ignore (silent agreement with the respective subsystem maintainer's opinion);
> >> 4) ...something I forgot?..
> >>
> >> (even partial) Rb != Ack.
So the patch contents is fine, but commit msg is not? OK, thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-05 16:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 8:27 [PATCH v2] docs: submitting-patches: Clarify half-baked review tags Krzysztof Kozlowski
2026-11-05 8:50 ` Wolfram Sang
2026-11-05 8:57 ` Krzysztof Kozlowski
2026-11-05 9:06 ` Wolfram Sang
2026-11-05 9:12 ` Krzysztof Kozlowski
2026-11-05 9:26 ` Andy Shevchenko
2026-11-05 10:59 ` Krzysztof Kozlowski
2026-11-05 9:28 ` Wolfram Sang
2026-11-05 11:03 ` Krzysztof Kozlowski
2026-11-05 11:19 ` Wolfram Sang
2026-11-05 11:53 ` Andy Shevchenko
2026-11-05 12:56 ` Krzysztof Kozlowski
2026-11-05 14:14 ` Andy Shevchenko
2026-11-05 9:29 ` Geert Uytterhoeven
2026-11-05 9:44 ` Wolfram Sang
2026-11-05 9:47 ` Andy Shevchenko
2026-11-05 9:19 ` Andy Shevchenko
2026-11-05 9:27 ` Krzysztof Kozlowski
2026-11-05 9:48 ` Andy Shevchenko
2026-11-05 10:55 ` Krzysztof Kozlowski
2026-11-05 9:30 ` Jürgen Groß
2026-11-05 15:33 ` Krzysztof Kozlowski
2026-11-05 15:44 ` Juergen Gross
2026-11-05 15:53 ` Krzysztof Kozlowski
2026-11-05 15:59 ` Jürgen Groß
2026-11-05 16:22 ` Krzysztof Kozlowski [this message]
2026-11-09 23:42 ` Andy Shevchenko
2026-11-09 23:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d535c77-eca2-4774-a327-e301a4f6c34d@kernel.org \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=jgross@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=workflows@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.