All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] ASoC: dt-bindings: qcom: Add Shikra RX and VA macro compatibles
Date: Tue, 15 Sep 2026 18:08:38 +0530	[thread overview]
Message-ID: <3d5a1cb8-defa-4252-8faa-8219752c59a9@oss.qualcomm.com> (raw)
In-Reply-To: <2345a7db-d9da-4a21-98e6-e3d622174a9f@kernel.org>



On 9/13/2026 2:19 PM, Krzysztof Kozlowski wrote:
> On 13/09/2026 10:48, Krzysztof Kozlowski wrote:
>> On Thu, Sep 10, 2026 at 03:16:52PM +0530, Mohammad Rafi Shaik wrote:
>>> Add bindings for Qualcomm shikra rx and va macro codec.
>>>
>>> Shikra integrates LPASS codec version 4.1, which is not backwards
>>> compatible with the already described compatibles.
>>
>> OK, so it is not compatible with anything so far, thus existing
>> constraints from the binding do not apply. Then why are the clock inputs
>> flexible?
>>
> 
> Heh, and you already received EXACTLY the same feedback at v1, which you
> completely ignored.
> 
> So now second time...

Sorry for overlooking this feedback. I had initially intended to handle 
the clock constraints in a separate DT series, but that was not the 
right approach.

This was my mistake.

I will update the patch to add the required clock constraints for the 
new Shikra LPASS codec bindings and address the issue in the next revision.

Best Regard's
Rafi.

> 
> Best regards,
> Krzysztof


  reply	other threads:[~2026-09-15 12:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  9:46 [PATCH v2 0/6] ASoC: qcom: Add shikra LPASS RX/VA macro support Mohammad Rafi Shaik
2026-09-10  9:46 ` [PATCH v2 1/6] ASoC: dt-bindings: qcom: Add Shikra RX and VA macro compatibles Mohammad Rafi Shaik
2026-09-10  9:53   ` sashiko-bot
2026-09-13  8:48   ` Krzysztof Kozlowski
2026-09-13  8:49     ` Krzysztof Kozlowski
2026-09-15 12:38       ` Mohammad Rafi Shaik [this message]
2026-09-10  9:46 ` [PATCH v2 2/6] ASoC: qcom: lpass-macro-common: Add missing v2.9 version string Mohammad Rafi Shaik
2026-09-14 11:43   ` Srinivas Kandagatla
2026-09-10  9:46 ` [PATCH v2 3/6] ASoC: qcom: lpass-macro-common: Add LPASS codec version 4.1 Mohammad Rafi Shaik
2026-09-13  8:46   ` Krzysztof Kozlowski
2026-09-15 12:41     ` Mohammad Rafi Shaik
2026-09-10  9:46 ` [PATCH v2 4/6] ASoC: qcom: lpass-rx-macro: Add shikra compatible Mohammad Rafi Shaik
2026-09-10  9:59   ` sashiko-bot
2026-09-14 11:41   ` Srinivas Kandagatla
2026-09-15 12:50     ` Mohammad Rafi Shaik
2026-09-10  9:46 ` [PATCH v2 5/6] ASoC: qcom: lpass-va-macro: " Mohammad Rafi Shaik
2026-09-10 10:03   ` sashiko-bot
2026-09-14 11:47   ` Srinivas Kandagatla
2026-09-15 12:55     ` Mohammad Rafi Shaik
2026-09-10  9:46 ` [PATCH v2 6/6] ASoC: qcom: lpass-va-macro: Add SoundWire microphone mux support Mohammad Rafi Shaik
2026-09-10 10:00   ` sashiko-bot
2026-09-14 12:45   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d5a1cb8-defa-4252-8faa-8219752c59a9@oss.qualcomm.com \
    --to=mohammad.rafi.shaik@oss.qualcomm.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.