From: Dave Jiang <dave.jiang@intel.com>
To: Alison Schofield <alison.schofield@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jic23@kernel.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <iweiny@kernel.org>, Li Ming <ming.li@zohomail.com>
Cc: linux-cxl@vger.kernel.org
Subject: Re: [PATCH] cxl/Documentation: Spell out globbed sysfs attribute names
Date: Thu, 6 Aug 2026 10:16:07 -0700 [thread overview]
Message-ID: <3d761f1f-6ff2-42d6-a451-e013c45ce959@intel.com> (raw)
In-Reply-To: <20260804232014.2286549-1-alison.schofield@intel.com>
On 8/4/26 4:20 PM, Alison Schofield wrote:
> Four entries in sysfs-bus-cxl use braced globs to document groups of
> attributes. Where the glob factors out a common prefix, as in
> cap_{pmem,ram,type2,type3}, no individual attribute name appears in
> the file at all and none can be found by grep or get_abi.py search. In
> every case the glob also keys get_abi.py validate on the glob string,
> so duplicates against separately documented attributes go undetected.
>
> Replace the globs with consecutive What: lines for each attribute.
> These lines continue to share the existing metadata and description
> and follow the format used in sysfs-driver-ufs and sysfs-bus-iio.
>
> Also restore one missing blank line between entries.
>
> Verify with:
> python3 tools/docs/get_abi.py -D Documentation/ABI/testing validate
> python3 tools/docs/get_abi.py search cap_pmem
> python3 tools/docs/get_abi.py search create_ram_region
>
> validate reports no sysfs-bus-cxl warning, and both searches now return
> the stanza where they returned nothing before.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Applied to cxl/next
d7066cfc4187
> ---
>
> This caught my eye when reading DavidLohr's Back-Invalidate series
> that adds cap_bi to the cap_{pmem,ram,type2,type3} glob and then
> references it. I couldn't find it, not w grep and not w 'get_abi.py
> search'. None of the existing cap_* names can be found. This patch
> is independent of that series and happy to spin this to include
> cap_bi if needed.
>
> This intentionally does not address `get_abi.py undefined`, which still
> fails to match decoderX.Y attributes due to a bug in the ABI tooling.
> That will be fixed separately in linux-doc.
>
> Documentation/ABI/testing/sysfs-bus-cxl | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
> index 16a9b3d2e2c0..7352dbd70bc7 100644
> --- a/Documentation/ABI/testing/sysfs-bus-cxl
> +++ b/Documentation/ABI/testing/sysfs-bus-cxl
> @@ -201,7 +201,8 @@ Description:
> capability.
>
>
> -What: /sys/bus/cxl/devices/{port,endpoint}X/parent_dport
> +What: /sys/bus/cxl/devices/portX/parent_dport
> +What: /sys/bus/cxl/devices/endpointX/parent_dport
> Date: January, 2023
> KernelVersion: v6.3
> Contact: linux-cxl@vger.kernel.org
> @@ -258,7 +259,8 @@ Description:
> instance id of a given decoder resource.
>
>
> -What: /sys/bus/cxl/devices/decoderX.Y/{start,size}
> +What: /sys/bus/cxl/devices/decoderX.Y/start
> +What: /sys/bus/cxl/devices/decoderX.Y/size
> Date: June, 2021
> KernelVersion: v5.14
> Contact: linux-cxl@vger.kernel.org
> @@ -297,7 +299,10 @@ Description:
> Each entry in the list is a dport id.
>
>
> -What: /sys/bus/cxl/devices/decoderX.Y/cap_{pmem,ram,type2,type3}
> +What: /sys/bus/cxl/devices/decoderX.Y/cap_pmem
> +What: /sys/bus/cxl/devices/decoderX.Y/cap_ram
> +What: /sys/bus/cxl/devices/decoderX.Y/cap_type2
> +What: /sys/bus/cxl/devices/decoderX.Y/cap_type3
> Date: June, 2021
> KernelVersion: v5.14
> Contact: linux-cxl@vger.kernel.org
> @@ -410,7 +415,8 @@ Description:
> interleave_granularity).
>
>
> -What: /sys/bus/cxl/devices/decoderX.Y/create_{pmem,ram}_region
> +What: /sys/bus/cxl/devices/decoderX.Y/create_pmem_region
> +What: /sys/bus/cxl/devices/decoderX.Y/create_ram_region
> Date: May, 2022, January, 2023
> KernelVersion: v6.0 (pmem), v6.3 (ram)
> Contact: linux-cxl@vger.kernel.org
> @@ -500,6 +506,7 @@ Description:
> cache is present, the size indicates extended linear cache size
> plus the CXL region size.
>
> +
> What: /sys/bus/cxl/devices/regionZ/extended_linear_cache_size
> Date: October, 2025
> KernelVersion: v6.19
>
prev parent reply other threads:[~2026-08-06 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 23:20 [PATCH] cxl/Documentation: Spell out globbed sysfs attribute names Alison Schofield
2026-08-04 23:24 ` Dave Jiang
2026-08-04 23:29 ` Alison Schofield
2026-08-06 17:16 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d761f1f-6ff2-42d6-a451-e013c45ce959@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave@stgolabs.net \
--cc=iweiny@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.