All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jic23@kernel.org>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <iweiny@kernel.org>, "Li Ming" <ming.li@zohomail.com>,
	<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH] cxl/Documentation: Spell out globbed sysfs attribute names
Date: Tue, 4 Aug 2026 16:29:20 -0700	[thread overview]
Message-ID: <anJ10CSmq05cnNGt@aschofie-mobl2.lan> (raw)
In-Reply-To: <850eb9c4-8f3e-4fa1-b8b5-46f83f5f20c1@intel.com>

On Tue, Aug 04, 2026 at 04:24:17PM -0700, Dave Jiang wrote:
> 
> 
> On 8/4/26 4:20 PM, Alison Schofield wrote:
> > Four entries in sysfs-bus-cxl use braced globs to document groups of
> > attributes. Where the glob factors out a common prefix, as in
> > cap_{pmem,ram,type2,type3}, no individual attribute name appears in
> > the file at all and none can be found by grep or get_abi.py search. In
> > every case the glob also keys get_abi.py validate on the glob string,
> > so duplicates against separately documented attributes go undetected.
> > 
> > Replace the globs with consecutive What: lines for each attribute.
> > These lines continue to share the existing metadata and description
> > and follow the format used in sysfs-driver-ufs and sysfs-bus-iio.
> > 
> > Also restore one missing blank line between entries.
> > 
> > Verify with:
> >   python3 tools/docs/get_abi.py -D Documentation/ABI/testing validate
> >   python3 tools/docs/get_abi.py search cap_pmem
> >   python3 tools/docs/get_abi.py search create_ram_region
> > 
> > validate reports no sysfs-bus-cxl warning, and both searches now return
> > the stanza where they returned nothing before.
> > 
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> 
> Seems reasonable. One comment below.
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> 

You're faster than Sashiko ;)
snip

> > +
> 
> Stray blank line?

It's mentioned in the commit log. 
"Also restore one missing blank line between entries."
Pattern is 2 blank lines btw entries.

> 
> >  What:		/sys/bus/cxl/devices/regionZ/extended_linear_cache_size
> >  Date:		October, 2025
> >  KernelVersion:	v6.19
> > 
> 

  reply	other threads:[~2026-08-04 23:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 23:20 [PATCH] cxl/Documentation: Spell out globbed sysfs attribute names Alison Schofield
2026-08-04 23:24 ` Dave Jiang
2026-08-04 23:29   ` Alison Schofield [this message]
2026-08-06 17:16 ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anJ10CSmq05cnNGt@aschofie-mobl2.lan \
    --to=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=iweiny@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.