All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Limpach <christian.limpach@gmail.com>
To: Arun Sharma <arun.sharma@intel.com>
Cc: Ian Pratt <Ian.Pratt@cl.cam.ac.uk>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86-64-phys-ma.patch
Date: Thu, 12 May 2005 23:04:42 +0100	[thread overview]
Message-ID: <3d8eece20505121504ff23632@mail.gmail.com> (raw)
In-Reply-To: <4283D10A.5080007@intel.com>

On 5/12/05, Arun Sharma <arun.sharma@intel.com> wrote:
> Christian Limpach wrote:
> > On 5/12/05, Arun Sharma <arun.sharma@intel.com> wrote:
> >
> >>phys is machine physical already. So we shouldn't try to convert guest physical to machine physical.
> >
> >
> > Are you sure that the test a few lines further down shouldn't use (a
> > to be defined -- see i386) pte_val_ma to compare the currently
> > installed pte with the to-be-installed one?  You might be comparing
> > random values otherwise...
> >
> 
> Sounds reasonable. I tested that this incremental patch doesn't cause
> any new regressions.

Thanks -- checked in.

     christian

      reply	other threads:[~2005-05-12 22:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-12 21:07 [PATCH] x86-64-phys-ma.patch Arun Sharma
2005-05-12 21:30 ` Christian Limpach
2005-05-12 21:56   ` Arun Sharma
2005-05-12 22:04     ` Christian Limpach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d8eece20505121504ff23632@mail.gmail.com \
    --to=christian.limpach@gmail.com \
    --cc=Christian.Limpach@cl.cam.ac.uk \
    --cc=Ian.Pratt@cl.cam.ac.uk \
    --cc=arun.sharma@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.