[PATCH] Fix xm list <Domname> so that it triggers an internal state update in Xend

[PATCH] Fix xm list <Domname> so that it triggers an internal state update in Xend

[Anthony Liguori]

[-- Attachment #1: Type: text/plain, Size: 103 bytes --]

Fix xm list <Domname> so that it triggers an internal state update in Xend.

Regards,

Anthony Liguori

[-- Attachment #2: 6553_xm.diff --]
[-- Type: text/x-patch, Size: 994 bytes --]

# HG changeset patch
# User Anthony Liguori <aliguori@us.ibm.com>
# Node ID eb6ce6e19ac4eb1bde83eaae8cea7a35ed6350e7
# Parent  8af8ddf9107832cfe509ffe8e9f7ee65856b2fa3
Fix xm list so that we trigger Xend to update its internal state even when
info is requested for individual domains.

Signed-off-by: Anthony Liguori

diff -r 8af8ddf91078 -r eb6ce6e19ac4 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py	Wed Aug 31 14:53:43 2005
+++ b/tools/python/xen/xm/main.py	Wed Aug 31 22:43:31 2005
@@ -222,11 +222,16 @@
 
     domsinfo = []
     from xen.xend.XendClient import server
-    if n == 0:
-        doms = server.xend_domains()
-        doms.sort()
-    else:
+
+    # FIXME
+    # a bit of a hack, we need to call xend_domains to refresh xend's internal
+    # domain state.
+    doms = server.xend_domains()
+    doms.sort()
+
+    if n != 0:
         doms = params
+
     for dom in doms:
         info = server.xend_domain(dom)
         domsinfo.append(parse_doms_info(info))

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] Fix xm list <Domname> so that it triggers an internal state update in Xend

[Anthony Liguori]

Hey Christian,

BTW, this bug is also present in 2.0 (there's a bug filed in bugzilla 
about it).

I'm going to close the bug report and defer to you guys to decide 
whether it's worth applying to 2.0 too.

Thanks,

Anthony Liguori

Anthony Liguori wrote:

> Fix xm list <Domname> so that it triggers an internal state update in 
> Xend.
>
> Regards,
>
> Anthony Liguori
>
>------------------------------------------------------------------------
>
># HG changeset patch
># User Anthony Liguori <aliguori@us.ibm.com>
># Node ID eb6ce6e19ac4eb1bde83eaae8cea7a35ed6350e7
># Parent  8af8ddf9107832cfe509ffe8e9f7ee65856b2fa3
>Fix xm list so that we trigger Xend to update its internal state even when
>info is requested for individual domains.
>
>Signed-off-by: Anthony Liguori
>
>diff -r 8af8ddf91078 -r eb6ce6e19ac4 tools/python/xen/xm/main.py
>--- a/tools/python/xen/xm/main.py	Wed Aug 31 14:53:43 2005
>+++ b/tools/python/xen/xm/main.py	Wed Aug 31 22:43:31 2005
>@@ -222,11 +222,16 @@
> 
>     domsinfo = []
>     from xen.xend.XendClient import server
>-    if n == 0:
>-        doms = server.xend_domains()
>-        doms.sort()
>-    else:
>+
>+    # FIXME
>+    # a bit of a hack, we need to call xend_domains to refresh xend's internal
>+    # domain state.
>+    doms = server.xend_domains()
>+    doms.sort()
>+
>+    if n != 0:
>         doms = params
>+
>     for dom in doms:
>         info = server.xend_domain(dom)
>         domsinfo.append(parse_doms_info(info))
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
>  
>

Re: [PATCH] Fix xm list <Domname> so that it triggers an internal state update in Xend

[Christian Limpach]

On 8/31/05, Anthony Liguori <aliguori@us.ibm.com> wrote:
> Fix xm list <Domname> so that it triggers an internal state update in Xend.

Thanks, but I think it's preferable to change the server side to
always return updated information when information on a single domain
is requested.  I've checked in changes to that effect.

    christian

Re: [PATCH] Fix xm list <Domname> so that it triggers an internal state update in Xend

[Anthony Liguori]

Christian Limpach wrote:

>On 8/31/05, Anthony Liguori <aliguori@us.ibm.com> wrote:
>  
>
>>Fix xm list <Domname> so that it triggers an internal state update in Xend.
>>    
>>
>
>Thanks, but I think it's preferable to change the server side to
>always return updated information when information on a single domain
>is requested.  I've checked in changes to that effect.
>  
>
Cool, that was the right fix.  I didn't realize it was so easy to fix it 
this way.

Thanks!

Regards,

Anthony Liguori

>    christian
>
>  
>