From: Christian Limpach <christian.limpach@gmail.com>
To: Dan Smith <danms@us.ibm.com>
Cc: Xen Tools Developers <xen-tools@lists.xensource.com>,
Xen Developers <xen-devel@lists.xensource.com>
Subject: Re: [Xen-tools] [PATCH] Clean up dom_get() usage
Date: Fri, 16 Sep 2005 20:22:14 +0100 [thread overview]
Message-ID: <3d8eece20509161222782a9051@mail.gmail.com> (raw)
In-Reply-To: <87irx2xnf3.fsf@us.ibm.com>
On 9/15/05, Dan Smith <danms@us.ibm.com> wrote:
The 1st hunk adds a random empty line, please avoid hunks like that in
the future.
> This patch adds sanity checks everywhere dom_get() is used.
I don't think the 3rd hunk is needed. It would make more sense to
have a patch which replaces the magic dom0 domid by a global variable
indicating the domid of the domain where xend is running.
> In the case of XendDomainInfo.update(), if we get None back from
> dom_get(), we destroy ourselves. I believe that this should be the
> desired behavior, but arguments to the contrary are welcome.
It's possibly a sensible behaviour, but I'd like to move away from
code which does stuff as a side effect. We don't want to end up with
countless places doing random actions just because they happen to
notice a state change first.
christian
next prev parent reply other threads:[~2005-09-16 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 17:15 [PATCH] Clean up dom_get() usage Dan Smith
2005-09-16 19:22 ` Christian Limpach [this message]
2005-09-16 20:57 ` [Xen-tools] " Dan Smith
2005-09-16 22:03 ` Christian Limpach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d8eece20509161222782a9051@mail.gmail.com \
--to=christian.limpach@gmail.com \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=danms@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
--cc=xen-tools@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.