From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Igor Pylypiv <ipylypiv@google.com>,
Terrence Adams <tadamsjr@google.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 01/10] scsi: pm80xx: Restore support for expanders
Date: Fri, 15 Aug 2025 11:30:15 +0900 [thread overview]
Message-ID: <3e710f91-efe0-4241-9d2f-bdca9f28d5e6@kernel.org> (raw)
In-Reply-To: <20250814173215.1765055-13-cassel@kernel.org>
On 8/15/25 02:32, Niklas Cassel wrote:
> Commit 0f630c58e31a ("scsi: pm80xx: Do not use libsas port ID") broke
> support for expanders. After the commit, devices behind an expander are no
> longer detected.
>
> Simply reverting the commit restores support for devices behind an
> expander.
>
> Instead of reverting the commit (and reintroducing a helper to get the
> port), get the port directly from the lldd_port pointer in struct
> asd_sas_port.
>
> Fixes: 0f630c58e31a ("scsi: pm80xx: Do not use libsas port ID")
> Suggested-by: Igor Pylypiv <ipylypiv@google.com>
> Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Tested-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-08-15 2:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 17:32 [PATCH v2 00/10] scsi: pm80xx: Fix expander support Niklas Cassel
2025-08-14 17:32 ` [PATCH v2 01/10] scsi: pm80xx: Restore support for expanders Niklas Cassel
2025-08-15 2:30 ` Damien Le Moal [this message]
2025-08-14 17:32 ` [PATCH v2 02/10] scsi: pm80xx: Fix array-index-out-of-of-bounds on rmmod Niklas Cassel
2025-08-15 2:30 ` Damien Le Moal
2025-08-14 17:32 ` [PATCH v2 03/10] scsi: libsas: Add dev_parent_is_expander() helper Niklas Cassel
2025-08-15 2:31 ` Damien Le Moal
2025-08-15 7:07 ` John Garry
2025-08-15 8:42 ` John Garry
2025-08-18 3:07 ` Jason Yan
2025-08-14 17:32 ` [PATCH v2 04/10] scsi: hisi_sas: Use " Niklas Cassel
2025-08-15 2:31 ` Damien Le Moal
2025-08-15 8:32 ` John Garry
2025-08-14 17:32 ` [PATCH v2 05/10] scsi: isci: " Niklas Cassel
2025-08-15 2:32 ` Damien Le Moal
2025-08-15 8:33 ` John Garry
2025-08-14 17:32 ` [PATCH v2 06/10] scsi: mvsas: " Niklas Cassel
2025-08-15 2:32 ` Damien Le Moal
2025-08-15 8:33 ` John Garry
2025-08-14 17:32 ` [PATCH v2 07/10] scsi: pm80xx: " Niklas Cassel
2025-08-15 2:33 ` Damien Le Moal
2025-08-15 8:34 ` John Garry
2025-08-15 16:39 ` Igor Pylypiv
2025-08-18 7:45 ` Jinpu Wang
2025-08-14 17:32 ` [PATCH v2 08/10] scsi: pm80xx: Add helper function to get the local phy id Niklas Cassel
2025-08-15 2:34 ` Damien Le Moal
2025-08-14 17:32 ` [PATCH v2 09/10] scsi: pm80xx: Fix pm8001_abort_task() for chip_8006 when using an expander Niklas Cassel
2025-08-15 2:35 ` Damien Le Moal
2025-08-14 17:32 ` [PATCH v2 10/10] scsi: pm80xx: Use pm80xx_get_local_phy_id() to access phy array Niklas Cassel
2025-08-15 2:36 ` Damien Le Moal
2025-08-15 16:40 ` Igor Pylypiv
2025-08-18 7:46 ` Jinpu Wang
2025-08-19 2:10 ` [PATCH v2 00/10] scsi: pm80xx: Fix expander support Martin K. Petersen
2025-08-26 2:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e710f91-efe0-4241-9d2f-bdca9f28d5e6@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=cassel@kernel.org \
--cc=ipylypiv@google.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tadamsjr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.