All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helen Koike <helen.koike@collabora.com>
To: Vignesh Raman <vignesh.raman@collabora.com>,
	dri-devel@lists.freedesktop.org
Cc: guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com,
	david.heidelberg@collabora.com, daniels@collabora.com,
	gustavo.padovan@collabora.com,
	angelogioacchino.delregno@collabora.com, emma@anholt.net,
	robclark@freedesktop.org, robdclark@google.com,
	anholt@google.com, robdclark@gmail.com, airlied@gmail.com,
	daniel@ffwll.ch, jani.nikula@linux.intel.com, mripard@kernel.org,
	dmitry.baryshkov@linaro.org, matthias.bgg@gmail.com,
	agross@kernel.org, andersson@kernel.org,
	konrad.dybcio@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 6/9] arm64: defconfig: Enable DA9211 regulator
Date: Tue, 12 Sep 2023 13:56:49 -0300	[thread overview]
Message-ID: <3f1f1679-2d0a-d501-da9c-cb38088acef2@collabora.com> (raw)
In-Reply-To: <20230908152225.432139-7-vignesh.raman@collabora.com>



On 08/09/2023 12:22, Vignesh Raman wrote:
> Mediatek mt8173 board fails to boot with DA9211 regulator disabled.
> Enabling CONFIG_REGULATOR_DA9211=y in drm-ci fixes the issue.
> 
> So enable it in the defconfig since kernel-ci also requires it.

tbh, =m doesn't solve for mesa-ci (since we don't use an initrd, not 
sure if it solves for kernel-ci.

> 
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.co
In any case:

Acked-by: Helen Koike <helen.koike@collabora.com>

> ---
> 
> v3:
>    - New patch in the series to enable CONFIG_REGULATOR_DA9211 in defconfig
> 
> ---
>   arch/arm64/configs/defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index a25d783dfb95..ef22b532b63a 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -711,6 +711,7 @@ CONFIG_REGULATOR_AXP20X=y
>   CONFIG_REGULATOR_BD718XX=y
>   CONFIG_REGULATOR_BD9571MWV=y
>   CONFIG_REGULATOR_CROS_EC=y
> +CONFIG_REGULATOR_DA9211=m

Question for the maintainers: would it be acceptable to make it a =y 
instead of =m here ? Since this is something required for booting.

Regards,
Helen

>   CONFIG_REGULATOR_FAN53555=y
>   CONFIG_REGULATOR_GPIO=y
>   CONFIG_REGULATOR_HI6421V530=y

WARNING: multiple messages have this Message-ID (diff)
From: Helen Koike <helen.koike@collabora.com>
To: Vignesh Raman <vignesh.raman@collabora.com>,
	dri-devel@lists.freedesktop.org
Cc: emma@anholt.net, virtualization@lists.linux-foundation.org,
	krzysztof.kozlowski+dt@linaro.org, robdclark@google.com,
	david.heidelberg@collabora.com, sergi.blanch.torne@collabora.com,
	gustavo.padovan@collabora.com, agross@kernel.org,
	devicetree@vger.kernel.org, conor+dt@kernel.org,
	daniels@collabora.com, linux-arm-msm@vger.kernel.org,
	mripard@kernel.org, anholt@google.com,
	linux-mediatek@lists.infradead.org, robclark@freedesktop.org,
	matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
	guilherme.gallo@collabora.com, linux-kernel@vger.kernel.org,
	konrad.dybcio@linaro.org, robh+dt@kernel.org,
	dmitry.baryshkov@linaro.org, andersson@kernel.org
Subject: Re: [PATCH v3 6/9] arm64: defconfig: Enable DA9211 regulator
Date: Tue, 12 Sep 2023 13:56:49 -0300	[thread overview]
Message-ID: <3f1f1679-2d0a-d501-da9c-cb38088acef2@collabora.com> (raw)
In-Reply-To: <20230908152225.432139-7-vignesh.raman@collabora.com>



On 08/09/2023 12:22, Vignesh Raman wrote:
> Mediatek mt8173 board fails to boot with DA9211 regulator disabled.
> Enabling CONFIG_REGULATOR_DA9211=y in drm-ci fixes the issue.
> 
> So enable it in the defconfig since kernel-ci also requires it.

tbh, =m doesn't solve for mesa-ci (since we don't use an initrd, not 
sure if it solves for kernel-ci.

> 
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.co
In any case:

Acked-by: Helen Koike <helen.koike@collabora.com>

> ---
> 
> v3:
>    - New patch in the series to enable CONFIG_REGULATOR_DA9211 in defconfig
> 
> ---
>   arch/arm64/configs/defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index a25d783dfb95..ef22b532b63a 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -711,6 +711,7 @@ CONFIG_REGULATOR_AXP20X=y
>   CONFIG_REGULATOR_BD718XX=y
>   CONFIG_REGULATOR_BD9571MWV=y
>   CONFIG_REGULATOR_CROS_EC=y
> +CONFIG_REGULATOR_DA9211=m

Question for the maintainers: would it be acceptable to make it a =y 
instead of =m here ? Since this is something required for booting.

Regards,
Helen

>   CONFIG_REGULATOR_FAN53555=y
>   CONFIG_REGULATOR_GPIO=y
>   CONFIG_REGULATOR_HI6421V530=y

  parent reply	other threads:[~2023-09-12 16:57 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 15:22 [PATCH v3 0/9] drm: ci: fixes Vignesh Raman
2023-09-08 15:22 ` Vignesh Raman
2023-09-08 15:22 ` [PATCH v3 1/9] drm: ci: igt_runner: Remove todo Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-12 16:50   ` Helen Koike
2023-09-12 16:50     ` Helen Koike
2023-09-08 15:22 ` [PATCH v3 2/9] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-11  7:56   ` Maxime Ripard
2023-09-11  7:56     ` Maxime Ripard
2023-09-11  8:09   ` Krzysztof Kozlowski
2023-09-11  8:09     ` Krzysztof Kozlowski
2023-09-11 11:50   ` Konrad Dybcio
2023-09-11 11:50     ` Konrad Dybcio
2023-09-11 12:38     ` Vignesh Raman
2023-09-11 12:38       ` Vignesh Raman
2023-09-12 16:51   ` Helen Koike
2023-09-12 16:51     ` Helen Koike
2023-09-08 15:22 ` [PATCH v3 3/9] drm: ci: Force db410c to " Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-11  7:56   ` Maxime Ripard
2023-09-11  7:56     ` Maxime Ripard
2023-09-12 16:52   ` Helen Koike
2023-09-12 16:52     ` Helen Koike
2023-09-08 15:22 ` [PATCH v3 4/9] drm: ci: virtio: Update ci variables Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-12 16:52   ` Helen Koike
2023-09-12 16:52     ` Helen Koike
2023-09-08 15:22 ` [PATCH v3 5/9] drm: ci: Enable regulator Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-12 16:53   ` Helen Koike
2023-09-08 15:22 ` [PATCH v3 6/9] arm64: defconfig: Enable DA9211 regulator Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-11  9:04   ` AngeloGioacchino Del Regno
2023-09-11  9:04     ` AngeloGioacchino Del Regno
2023-09-12 16:56   ` Helen Koike [this message]
2023-09-12 16:56     ` Helen Koike
2023-09-08 15:22 ` [PATCH v3 7/9] drm: ci: Update xfails Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-08 15:22 ` [PATCH v3 8/9] drm: ci: Enable new jobs Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-12 17:01   ` Helen Koike
2023-09-12 17:01     ` Helen Koike
2023-09-08 15:22 ` [PATCH v3 9/9] drm: ci: Use scripts/config to enable/disable configs Vignesh Raman
2023-09-08 15:22   ` Vignesh Raman
2023-09-12 17:01   ` Helen Koike
2023-09-12 17:01     ` Helen Koike
2023-09-11  8:06 ` [PATCH v3 0/9] drm: ci: fixes Krzysztof Kozlowski
2023-09-11  8:06   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f1f1679-2d0a-d501-da9c-cb38088acef2@collabora.com \
    --to=helen.koike@collabora.com \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=anholt@google.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=david.heidelberg@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=guilherme.gallo@collabora.com \
    --cc=gustavo.padovan@collabora.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=robclark@freedesktop.org \
    --cc=robdclark@gmail.com \
    --cc=robdclark@google.com \
    --cc=robh+dt@kernel.org \
    --cc=sergi.blanch.torne@collabora.com \
    --cc=vignesh.raman@collabora.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.