From: Krzysztof Kozlowski <krzk@kernel.org>
To: sashiko-reviews@lists.linux.dev,
Flaviu Nistor <flaviu.nistor@gmail.com>,
Roman Gushchin <roman.gushchin@linux.dev>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (lm75) Add explicit header include
Date: Sat, 16 May 2026 10:14:31 +0200 [thread overview]
Message-ID: <3f20b310-fd59-46d7-ad1f-201c755b690a@kernel.org> (raw)
In-Reply-To: <20260516080647.4C31AC19425@smtp.kernel.org>
On 16/05/2026 10:06, sashiko-bot@kernel.org wrote:
>> Since device_property_read_string() is used in the
>> probe function add explicit include for
>> linux/mod_devicetable.h and linux/property.h rather
>> than having implicit inclusions.
>> Header linux/of.h can be removed and also of_match_ptr()
>> improving non-Device Tree compatibility of the driver.
>>
>> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
>
> Reviewed-by: Sashiko <sashiko-bot@kernel.org>
>
NAK, fake tag.
https://lore.kernel.org/r/ad139e54-a7f0-4d09-832c-6b2bf2e93e03@kernel.org
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-16 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 7:57 [PATCH] hwmon: (lm75) Add explicit header include Flaviu Nistor
2026-05-16 8:06 ` sashiko-bot
2026-05-16 8:14 ` Krzysztof Kozlowski [this message]
2026-05-16 12:14 ` Guenter Roeck
2026-05-16 12:27 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f20b310-fd59-46d7-ad1f-201c755b690a@kernel.org \
--to=krzk@kernel.org \
--cc=flaviu.nistor@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.