[PATCH] hwmon: (lm75) Add explicit header include

[PATCH] hwmon: (lm75) Add explicit header include

[Flaviu Nistor]

Since device_property_read_string() is used in the
probe function add explicit include for
linux/mod_devicetable.h and linux/property.h rather
than having implicit inclusions.
Header linux/of.h can be removed and also of_match_ptr()
improving non-Device Tree compatibility of the driver.

Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
 drivers/hwmon/lm75.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index 845a0e09ea9f..32279049d44c 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -14,7 +14,8 @@
 #include <linux/i3c/device.h>
 #include <linux/hwmon.h>
 #include <linux/err.h>
-#include <linux/of.h>
+#include <linux/mod_devicetable.h>
+#include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/util_macros.h>
 #include <linux/regulator/consumer.h>
@@ -1152,7 +1153,7 @@ static struct i2c_driver lm75_i2c_driver = {
 	.class		= I2C_CLASS_HWMON,
 	.driver = {
 		.name	= "lm75",
-		.of_match_table = of_match_ptr(lm75_of_match),
+		.of_match_table = lm75_of_match,
 		.pm	= LM75_DEV_PM_OPS,
 	},
 	.probe		= lm75_i2c_probe,
-- 
2.34.1

Re: [PATCH] hwmon: (lm75) Add explicit header include

[sashiko-bot]

> Since device_property_read_string() is used in the
> probe function add explicit include for
> linux/mod_devicetable.h and linux/property.h rather
> than having implicit inclusions.
> Header linux/of.h can be removed and also of_match_ptr()
> improving non-Device Tree compatibility of the driver.
> 
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>

Reviewed-by: Sashiko <sashiko-bot@kernel.org>

Re: [PATCH] hwmon: (lm75) Add explicit header include

[Krzysztof Kozlowski]

On 16/05/2026 10:06, sashiko-bot@kernel.org wrote:
>> Since device_property_read_string() is used in the
>> probe function add explicit include for
>> linux/mod_devicetable.h and linux/property.h rather
>> than having implicit inclusions.
>> Header linux/of.h can be removed and also of_match_ptr()
>> improving non-Device Tree compatibility of the driver.
>>
>> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> 
> Reviewed-by: Sashiko <sashiko-bot@kernel.org>
> 

NAK, fake tag.

https://lore.kernel.org/r/ad139e54-a7f0-4d09-832c-6b2bf2e93e03@kernel.org

Best regards,
Krzysztof

Re: [PATCH] hwmon: (lm75) Add explicit header include

[Guenter Roeck]

On 5/16/26 01:14, Krzysztof Kozlowski wrote:
> On 16/05/2026 10:06, sashiko-bot@kernel.org wrote:
>>> Since device_property_read_string() is used in the
>>> probe function add explicit include for
>>> linux/mod_devicetable.h and linux/property.h rather
>>> than having implicit inclusions.
>>> Header linux/of.h can be removed and also of_match_ptr()
>>> improving non-Device Tree compatibility of the driver.
>>>
>>> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
>>
>> Reviewed-by: Sashiko <sashiko-bot@kernel.org>
>>
> 
> NAK, fake tag.
> 

Until and unless there is an official policy that explicitly states
that AI agents MUST NOT provide Reviewed-by: tags, I will ignore your
NAKs on patches submitted in my scope of responsibility. Please point
to the policy, not to your opinion about review feedback from AI agents.

Thanks,
Guenter

Re: [PATCH] hwmon: (lm75) Add explicit header include

[Guenter Roeck]

On Sat, May 16, 2026 at 10:57:08AM +0300, Flaviu Nistor wrote:
> Since device_property_read_string() is used in the
> probe function add explicit include for
> linux/mod_devicetable.h and linux/property.h rather
> than having implicit inclusions.
> Header linux/of.h can be removed and also of_match_ptr()
> improving non-Device Tree compatibility of the driver.
> 

Line breaks should be at column 75. There are way too many line breaks
above.

> ---
>  drivers/hwmon/lm75.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 845a0e09ea9f..32279049d44c 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -14,7 +14,8 @@
>  #include <linux/i3c/device.h>
>  #include <linux/hwmon.h>
>  #include <linux/err.h>
> -#include <linux/of.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/property.h>
>  #include <linux/regmap.h>
>  #include <linux/util_macros.h>
>  #include <linux/regulator/consumer.h>
> @@ -1152,7 +1153,7 @@ static struct i2c_driver lm75_i2c_driver = {
>  	.class		= I2C_CLASS_HWMON,
>  	.driver = {
>  		.name	= "lm75",
> -		.of_match_table = of_match_ptr(lm75_of_match),
> +		.of_match_table = lm75_of_match,

With this, the __maybe_unused in the declaration of lm75_of_match
is no longer necessary. Please drop.

Thanks,
Guenter