All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-clk@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/8] clk: Replace four seq_printf() calls by seq_putc()
Date: Thu, 20 Apr 2017 08:27:29 +0000	[thread overview]
Message-ID: <3f7979fe-3dc0-e6d1-b13b-ea3d990ecf91@users.sourceforge.net> (raw)
In-Reply-To: <94b24eaa-c5fb-80ea-441a-883989d14ef5@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 20 Apr 2017 08:45:43 +0200

Four single characters should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/clk/clk.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 67201f67a14a..4c72a10a9a33 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2081,11 +2081,11 @@ static void clk_dump_subtree(struct seq_file *s, struct clk_core *c, int level)
 	clk_dump_one(s, c, level);
 
 	hlist_for_each_entry(child, &c->children, child_node) {
-		seq_printf(s, ",");
+		seq_putc(s, ',');
 		clk_dump_subtree(s, child, level + 1);
 	}
 
-	seq_printf(s, "}");
+	seq_putc(s, '}');
 }
 
 static int clk_dump(struct seq_file *s, void *data)
@@ -2094,14 +2094,13 @@ static int clk_dump(struct seq_file *s, void *data)
 	bool first_node = true;
 	struct hlist_head **lists = (struct hlist_head **)s->private;
 
-	seq_printf(s, "{");
-
+	seq_putc(s, '{');
 	clk_prepare_lock();
 
 	for (; *lists; lists++) {
 		hlist_for_each_entry(c, *lists, child_node) {
 			if (!first_node)
-				seq_puts(s, ",");
+				seq_putc(s, ',');
 			first_node = false;
 			clk_dump_subtree(s, c, 0);
 		}
-- 
2.12.2


WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-clk@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/8] clk: Replace four seq_printf() calls by seq_putc()
Date: Thu, 20 Apr 2017 10:27:29 +0200	[thread overview]
Message-ID: <3f7979fe-3dc0-e6d1-b13b-ea3d990ecf91@users.sourceforge.net> (raw)
In-Reply-To: <94b24eaa-c5fb-80ea-441a-883989d14ef5@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 20 Apr 2017 08:45:43 +0200

Four single characters should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/clk/clk.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 67201f67a14a..4c72a10a9a33 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2081,11 +2081,11 @@ static void clk_dump_subtree(struct seq_file *s, struct clk_core *c, int level)
 	clk_dump_one(s, c, level);
 
 	hlist_for_each_entry(child, &c->children, child_node) {
-		seq_printf(s, ",");
+		seq_putc(s, ',');
 		clk_dump_subtree(s, child, level + 1);
 	}
 
-	seq_printf(s, "}");
+	seq_putc(s, '}');
 }
 
 static int clk_dump(struct seq_file *s, void *data)
@@ -2094,14 +2094,13 @@ static int clk_dump(struct seq_file *s, void *data)
 	bool first_node = true;
 	struct hlist_head **lists = (struct hlist_head **)s->private;
 
-	seq_printf(s, "{");
-
+	seq_putc(s, '{');
 	clk_prepare_lock();
 
 	for (; *lists; lists++) {
 		hlist_for_each_entry(c, *lists, child_node) {
 			if (!first_node)
-				seq_puts(s, ",");
+				seq_putc(s, ',');
 			first_node = false;
 			clk_dump_subtree(s, c, 0);
 		}
-- 
2.12.2

  parent reply	other threads:[~2017-04-20  8:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  8:20 [PATCH 0/8] clk: Fine-tuning for ten function implementations SF Markus Elfring
2017-04-20  8:20 ` SF Markus Elfring
2017-04-20  8:22 ` [PATCH 1/8] clk: si5351: Use devm_kcalloc() in si5351_i2c_probe() SF Markus Elfring
2017-04-20  8:22   ` SF Markus Elfring
2017-04-22  2:44   ` Stephen Boyd
2017-04-22  2:44     ` Stephen Boyd
2017-04-20  8:23 ` [PATCH 2/8] clk: si5351: Delete an error message for a failed memory allocation in si5351_i2c_probe( SF Markus Elfring
2017-04-20  8:23   ` [PATCH 2/8] clk: si5351: Delete an error message for a failed memory allocation in si5351_i2c_probe() SF Markus Elfring
2017-04-22  2:45   ` [PATCH 2/8] clk: si5351: Delete an error message for a failed memory allocation in si5351_i2c_pr Stephen Boyd
2017-04-22  2:45     ` [PATCH 2/8] clk: si5351: Delete an error message for a failed memory allocation in si5351_i2c_probe() Stephen Boyd
2017-04-20  8:26 ` [PATCH 3/8] clk: si5351: Adjust a null pointer check in si5351_dt_parse() SF Markus Elfring
2017-04-20  8:26   ` SF Markus Elfring
2017-04-20  8:27 ` SF Markus Elfring [this message]
2017-04-20  8:27   ` [PATCH 4/8] clk: Replace four seq_printf() calls by seq_putc() SF Markus Elfring
2017-04-22  2:46   ` Stephen Boyd
2017-04-22  2:46     ` Stephen Boyd
2017-04-20  8:28 ` [PATCH 5/8] clk: Combine two seq_puts() calls into one call in clk_summary_show() SF Markus Elfring
2017-04-20  8:28   ` SF Markus Elfring
2017-04-20  8:29 ` [PATCH 6/8] clk: Improve a size determination in two functions SF Markus Elfring
2017-04-20  8:29   ` SF Markus Elfring
2017-04-22  2:47   ` Stephen Boyd
2017-04-22  2:47     ` Stephen Boyd
2017-04-20  8:30 ` [PATCH 7/8] clk: nomadik: Use seq_puts() in nomadik_src_clk_show() SF Markus Elfring
2017-04-20  8:30   ` SF Markus Elfring
2017-04-22  2:48   ` Stephen Boyd
2017-04-22  2:48     ` Stephen Boyd
2017-04-20  8:32 ` [PATCH 8/8] clk: nomadik: Delete error messages for a failed memory allocation in two functions SF Markus Elfring
2017-04-20  8:32   ` SF Markus Elfring
2017-04-22  2:48   ` Stephen Boyd
2017-04-22  2:48     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f7979fe-3dc0-e6d1-b13b-ea3d990ecf91@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.