From: Jens Axboe <axboe@kernel.dk>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: dead code in io_file_put()
Date: Sat, 13 Apr 2019 11:49:54 -0600 [thread overview]
Message-ID: <3f83273e-38ac-1016-2f37-60e33bc54304@kernel.dk> (raw)
In-Reply-To: <20190413172750.GN2217@ZenIV.linux.org.uk>
On 4/13/19 11:27 AM, Al Viro wrote:
> It's never called with NULL first argument anymore.
> Is there any reason to keep that check (and the second argument,
> never used when state != NULL) there?
Good catch, looks like that part can go now.
> Frankly, I wonder if there is any point in that
> fget_many()/fput_many() stuff. Does the benefit from that
> really show up in any profiles?
It certainly made a difference for higher IOPS workloads. Of course
we have the file registration now to negate that, but since we're
using the state anyway for iocb allocation, it'd be a shame to drop
the file ref cost amortization for the non-registered case.
--
Jens Axboe
prev parent reply other threads:[~2019-04-13 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 17:27 dead code in io_file_put() Al Viro
2019-04-13 17:49 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f83273e-38ac-1016-2f37-60e33bc54304@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.