Re: [dm-devel] [v2 2/4] dm ioctl: Allow userspace to provide expected diskseq

From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
	kernel-janitors@vger.kernel.org, dm-devel@redhat.com
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
	Mike Snitzer <snitzer@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [v2 2/4] dm ioctl: Allow userspace to provide expected diskseq
Date: Tue, 27 Jun 2023 09:19:02 +0200	[thread overview]
Message-ID: <3f9370ff-074a-1a14-fae7-e081d47e628c@web.de> (raw)
In-Reply-To: <ab9f1618-5dde-4c70-a88e-c65f33abdb73@kadam.mountain>

>> See also another bit of background information once more:
>> [PATCH v2] certs/extract-cert: Fix checkpatch issues
>> 2023-06-09
>> https://lore.kernel.org/kernel-janitors/c464c4ee-038c-47bf-857a-b11a89680e82@kadam.mountain/
>> https://lkml.org/lkml/2023/6/9/879
>
> Markus, it's not about imperative tense.  It's about you wasting
> people's time.
>
> Read the subject again.  "Allow userspace to provide expected diskseq".
> That is imperative tense.

Yes for the patch subject.
(Patch/commit descriptions can be adjusted accordingly.)

>                            I have not pointed it out to you because it
> just doesn't matter at all.  If it's in imperative tense or if it's not
> in imperative tense, it doesn't matter.

It seems that known development documentation expresses opposite requirements.

> You're sending out a lot of messages and quite a few times it looks like
> your targeting newbies.

I dare to send some change suggestions (or reminders) to various contributors.

>                          One new developer sent me an email privately
> who was over the top grateful when I told him he could ignore you.
> The guy was like, "I was so puzzled, because it's my first patch
> and I didn't know how to respond."

Thanks for such information.

>                                     This was an experienced programmer
> who we want, but he was new to the kernel community so he didn't know
> if we had bizarre rules or whatever.

There is some guidance available already.
Development experiences can and will grow further.

> I've looked through your patches that have recently been merged.

Thanks for another look.

> Some of those maintainers know that you are banned

Yes, of course.

> and that your patches are not getting any review from the mailing list.

Review approaches are generally improvable.

> We are really trying to be nice and to work around your situation.

Can remaining communication difficulties be resolved better anyhow?

> But don't start bothering newbies who don't know what the situation is.

I do not distinguish some of my patch feedback on the contributor category.

Regards,
Markus

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel