From: Ed Tanous <ed.tanous@intel.com>
To: openbmc@lists.ozlabs.org
Subject: Re: template replacement
Date: Mon, 12 Aug 2019 16:57:52 -0700 [thread overview]
Message-ID: <3f980968-f67f-1529-e681-e351c597a2ff@intel.com> (raw)
In-Reply-To: <CAO=notykGFd7Ux3k6OcsskrKTAxLa=vEiybFD3agPuqkGoYG-Q@mail.gmail.com>
On 8/12/19 9:10 AM, Patrick Venture wrote:
> I've run into an issue and before I submitted a patch to solve my
> specific problem, I wanted to get a sense of what was intended:
>
> I have a field "name" that I want to set dynamically to "$bus_v2345_0_local"
> It finds the $bus match but then fails on the split.
> If I add a " " it then fails as well.
>
Probably just a bug. A quick scan of $bus in the configurations shows
that we've only ever used it in cases where it was the complete string
(ie "$bus") and even then, only used to populate numeric interfaces with
the bus number to be used programmatically by downstream sensors.
Some of the intent was to largely remove the bus number from the device
naming convention, as outside the system the bus topology is largely
irrelevant. With that said, I could see how that might be desired for
some setups.
> It seems to be that if a template is at the end of the field, it works
> fine, otherwise it assumes there must be some operation to perform.
>
> Did you already have a fix in mind?
James is out the next few days, so his answer might differ from mine
when he gets back, but I don't think we knew about this issue previously.
next prev parent reply other threads:[~2019-08-12 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 16:10 template replacement Patrick Venture
2019-08-12 23:57 ` Ed Tanous [this message]
2019-08-13 0:00 ` Patrick Venture
2019-08-13 0:04 ` Patrick Venture
2019-08-13 22:51 ` James Feist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f980968-f67f-1529-e681-e351c597a2ff@intel.com \
--to=ed.tanous@intel.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.