From: shankerd@codeaurora.org (Shanker Donthineni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform
Date: Thu, 23 Feb 2017 15:05:42 -0600 [thread overview]
Message-ID: <3fb32277-9d9e-c84d-4e98-c19ace690433@codeaurora.org> (raw)
In-Reply-To: <4d97310a-4b91-07ac-1ce0-faacb8da03b0@codeaurora.org>
On 02/23/2017 02:46 PM, Timur Tabi wrote:
> On 02/23/2017 02:02 PM, Shanker Donthineni wrote:
>> The commit 38fd94b0275c 'arm64: Work around Falkor erratum 1003' has
>> been added to fix the hardware bug but causing a system crash. The
>
> "causes"
>
>> value of the register x1 which contains 'struct mm_struct *' should
>> be preserved inside macro pre_ttbr0_update_workaround.
>
> The subject line seems a bit vague and alarmist to me. In my opinion,
> this is more descriptive:
>
> arm64: qcom: pre_ttbr0_update_workaround should not clobber register x1
>
>
Why do you want keep 'pre_ttbr0_update_workaround' in subject, nothing
wrong with macro definition itself. Problem with the caller, not passing
the right arguments.
--
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: Shanker Donthineni <shankerd@codeaurora.org>
To: Timur Tabi <timur@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Vikram Sethi <vikrams@codeaurora.org>,
Will Deacon <will.deacon@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
James Morse <james.morse@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform
Date: Thu, 23 Feb 2017 15:05:42 -0600 [thread overview]
Message-ID: <3fb32277-9d9e-c84d-4e98-c19ace690433@codeaurora.org> (raw)
In-Reply-To: <4d97310a-4b91-07ac-1ce0-faacb8da03b0@codeaurora.org>
On 02/23/2017 02:46 PM, Timur Tabi wrote:
> On 02/23/2017 02:02 PM, Shanker Donthineni wrote:
>> The commit 38fd94b0275c 'arm64: Work around Falkor erratum 1003' has
>> been added to fix the hardware bug but causing a system crash. The
>
> "causes"
>
>> value of the register x1 which contains 'struct mm_struct *' should
>> be preserved inside macro pre_ttbr0_update_workaround.
>
> The subject line seems a bit vague and alarmist to me. In my opinion,
> this is more descriptive:
>
> arm64: qcom: pre_ttbr0_update_workaround should not clobber register x1
>
>
Why do you want keep 'pre_ttbr0_update_workaround' in subject, nothing
wrong with macro definition itself. Problem with the caller, not passing
the right arguments.
--
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-02-23 21:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 20:02 [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform Shanker Donthineni
2017-02-23 20:02 ` Shanker Donthineni
2017-02-23 20:46 ` Timur Tabi
2017-02-23 20:46 ` Timur Tabi
2017-02-23 21:05 ` Shanker Donthineni [this message]
2017-02-23 21:05 ` Shanker Donthineni
2017-02-23 21:11 ` Timur Tabi
2017-02-23 21:11 ` Timur Tabi
2017-02-23 21:34 ` Shanker Donthineni
2017-02-23 21:34 ` Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb32277-9d9e-c84d-4e98-c19ace690433@codeaurora.org \
--to=shankerd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.