From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: [PATCH v2] smaps: Report correct page sizes with THP
Date: Tue, 3 Mar 2026 17:14:45 +0100 [thread overview]
Message-ID: <3fb43e7e-8e00-4cd7-84e0-da4c88231b08@kernel.org> (raw)
In-Reply-To: <aacGi1DEZoc00Sv7@tassilo>
On 3/3/26 17:04, Andi Kleen wrote:
>
> BTW your comment earlier about partially mapped compound pages made
> me reconsider the code and unless I'm missing something the accounting
> is all wrong for this case anyways in the current code.
>
> The code currently calls smaps_account for every PTE, which will happily
> account the complete compound page
I suggest you re-read the code and realize how the misleading "compound"
parameter is used.
--
Cheers,
David
next prev parent reply other threads:[~2026-03-03 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 23:27 [PATCH v2] smaps: Report correct page sizes with THP Andi Kleen
2026-02-26 12:08 ` Usama Arif
2026-03-01 17:20 ` Andi Kleen
2026-02-26 17:31 ` David Hildenbrand (Arm)
2026-03-01 17:35 ` Andi Kleen
2026-03-02 19:29 ` David Hildenbrand (Arm)
2026-03-02 20:41 ` Andi Kleen
2026-03-02 21:05 ` David Hildenbrand (Arm)
2026-03-02 21:48 ` Andi Kleen
2026-03-03 9:05 ` David Hildenbrand (Arm)
2026-03-03 9:39 ` Lorenzo Stoakes
2026-03-03 15:34 ` Andi Kleen
2026-03-03 16:29 ` Lorenzo Stoakes
2026-03-03 16:04 ` Andi Kleen
2026-03-03 16:14 ` David Hildenbrand (Arm) [this message]
2026-03-03 9:27 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb43e7e-8e00-4cd7-84e0-da4c88231b08@kernel.org \
--to=david@kernel.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.