From: Andi Kleen <ak@linux.intel.com>
To: Usama Arif <usama.arif@linux.dev>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH v2] smaps: Report correct page sizes with THP
Date: Sun, 1 Mar 2026 09:20:37 -0800 [thread overview]
Message-ID: <aaR1W6evB8iylaxK@tassilo> (raw)
In-Reply-To: <20260226120818.408966-1-usama.arif@linux.dev>
> When a VMA has no resident pages (e.g., freshly mmap'd but not yet
> faulted), compound_orders will be zero and the for_each_set_bit loop
> will not execute at all. This means no MMUPageSize line is emitted
> for that VMA.
>
> Previously, vma_mmu_pagesize() was called unconditionally and always
> produced the MMUPageSize field. Userspace tools that parse smaps and
> expect MMUPageSize to always be present would break on VMAs with no
> resident pages. Should we always add it?
Yes that's a good point. Should fall back to the base page size
then. Will just make the simple logic a bit more complex again.
-Andi
next prev parent reply other threads:[~2026-03-01 17:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 23:27 [PATCH v2] smaps: Report correct page sizes with THP Andi Kleen
2026-02-26 12:08 ` Usama Arif
2026-03-01 17:20 ` Andi Kleen [this message]
2026-02-26 17:31 ` David Hildenbrand (Arm)
2026-03-01 17:35 ` Andi Kleen
2026-03-02 19:29 ` David Hildenbrand (Arm)
2026-03-02 20:41 ` Andi Kleen
2026-03-02 21:05 ` David Hildenbrand (Arm)
2026-03-02 21:48 ` Andi Kleen
2026-03-03 9:05 ` David Hildenbrand (Arm)
2026-03-03 9:39 ` Lorenzo Stoakes
2026-03-03 15:34 ` Andi Kleen
2026-03-03 16:29 ` Lorenzo Stoakes
2026-03-03 16:04 ` Andi Kleen
2026-03-03 16:14 ` David Hildenbrand (Arm)
2026-03-03 9:27 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaR1W6evB8iylaxK@tassilo \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=usama.arif@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.